New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emptyDrops does not terminate #14
Comments
You don't provide the call to
|
The output for sessionInfo() currently is: R version 3.6.0 (2019-04-26) Matrix products: default Random number generation: locale: attached base packages: other attached packages: loaded via a namespace (and not attached): |
And the call to emptyDrops is: emptyDrops(counts(sce)) |
I don't have much insight to give here. Your call and session information look fine to me. I have no problems running |
Could I send you the SCE RData object that reproduces this issue?
thanks
shui
…On Mon, May 27, 2019 at 2:53 PM Aaron Lun ***@***.***> wrote:
I don't have much insight to give here. Your call and session information
look fine to me. I have no problems running emptyDrops on a Mac, and it
works fine on the Bioconductor build system.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#14?email_source=notifications&email_token=ACTP5BUXXCAE5XJL5Y3FFFTPXQU3DA5CNFSM4HP37BDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWKLM4Y#issuecomment-496285299>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACTP5BTNP56JJ5PTD2HF4I3PXQU3DANCNFSM4HP37BDA>
.
|
I just noticed that your count matrix only has 1500 cells. You should really be running it on the raw count matrix prior to any cell calling; for a 10X experiment, this should have ~750,000 barcodes. So the real solution is to use the raw count matrix as input into |
Hello, Yes it has a small number of cells as I am QCing per batch and batch 5 only has 1588 cells?? The call to emptyDrops is the first call I make in QCing so prior to the call it is simply the raw count data loaded in. The RData object is here: When I run the following with Bioconductor 3.8 (in 3.9 the call to emptyDrops hangs)
[1] "Number empty drops: 1212 out of 1588"
Matrix products: default locale: attached base packages: other attached packages: loaded via a namespace (and not attached): |
I just want the count matrix that you're putting into |
Well, your Rdata file doesn't even have an load("so.qc.normsize.lognorm.scale.pca.tsne.res1.demarkers.12746.RCCTumour.RData")
library(DropletUtils)
system.time(out <- emptyDrops(so@raw.data)) The cause of this phenomenon is technically complex. For those who are interested, it seems that Boost's However, the exact cause is irrelevant. Regardless of whether it terminates or not, what you are doing is almost certainly wrong. Assuming this is 10X data, you need to be giving In fact, the real question is why the function ever worked in the first place - because it shouldn't have. (The problem with Boost only arises because the sum of ambient counts is zero.) So, I will add extra error checks to provide some defense against this, whereby the function will simply quit with an error if there are no low-count libraries available to estimate the ambient profile. |
My apologies, the RData is actually here (I sent the wrong link): It is 7-8MB. Sorry about that. Please find a single cell experiment object (sce) that is ~33K x 1588. It has not been QCd or normalized and contains raw counts. shui |
Perhaps I was less than clear.
If you are trying to run I have now modified the function so that you CANNOT do what you are trying to do. The function will simply fail with an error message. This is the only way to protect you from yourself. |
Yes you were less than clear to me but thanks for your help anyways. shui |
Hello,
I just upgraded to Bioconductor version 3.9.
When I run emptyDrops() on my count data it does not terminate (i.e. endless loop? goes on for hours). I have tried changing niters to be lower (i.e 100) but nothing seems to work.
When I revert back to Bioconductor version 3.8, emptyDrops works and terminates fine.
There are few emptyDrops detected overall (i.e. 5) but I would still like to know why it doesn't terminate when using the latest version. My count data is ~33K genes x ~1500 cells
Thanks
shui
The text was updated successfully, but these errors were encountered: