Skip to content

Commit

Permalink
Make highlighting effective for code-formatted text (#1215)
Browse files Browse the repository at this point in the history
Currently the background color of code tag is opaque, therefore the
highlighting will be covered by the code-formatted text. Let's
introduce transparency to code tag style when it's placed under
mark tag so that highlighting is effective in this case.
  • Loading branch information
le0tan committed Apr 25, 2020
1 parent 5db6351 commit 3a87264
Show file tree
Hide file tree
Showing 8 changed files with 32 additions and 0 deletions.
4 changes: 4 additions & 0 deletions asset/css/markbind.css
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ code {
word-break: normal;
}

mark code {
background: #ffffffd4;
}

pre.hljs > code {
background: none;
}
Expand Down
4 changes: 4 additions & 0 deletions test/functional/test_site/expected/markbind/css/markbind.css
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ code {
word-break: normal;
}

mark code {
background: #ffffffd4;
}

pre.hljs > code {
background: none;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ code {
word-break: normal;
}

mark code {
background: #ffffffd4;
}

pre.hljs > code {
background: none;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ code {
word-break: normal;
}

mark code {
background: #ffffffd4;
}

pre.hljs > code {
background: none;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ code {
word-break: normal;
}

mark code {
background: #ffffffd4;
}

pre.hljs > code {
background: none;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ code {
word-break: normal;
}

mark code {
background: #ffffffd4;
}

pre.hljs > code {
background: none;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ code {
word-break: normal;
}

mark code {
background: #ffffffd4;
}

pre.hljs > code {
background: none;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ code {
word-break: normal;
}

mark code {
background: #ffffffd4;
}

pre.hljs > code {
background: none;
}
Expand Down

0 comments on commit 3a87264

Please sign in to comment.