Make highlighting effective for code-formatted text #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can post a screenshot of an example output? |
|
@damithc here you go: highlight + code: normal code: normal highlight: |
Looks good 👍 |
nbriannl
approved these changes
Apr 22, 2020
openorclose
requested changes
Apr 22, 2020
openorclose
approved these changes
Apr 23, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Enhancement to an existing feature
Fixes #1210
Related to #1209
What changes did you make? (Give an overview)
Make the background transparent for code-formatted text under tag (i.e. highlighting)
Provide some example code that this change will affect:
na
Is there anything you'd like reviewers to focus on?
na
Testing instructions:
npm run testProposed commit message: (wrap lines at 72 characters)
Currently the background color of code tag is opaque, therefore the
highlighting will be covered by the code-formatted text. Let's
introduce transparency to code tag style when it's placed under
mark tag so that highlighting is effective in this case.