Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal panel button wrapper is on the next line #1979

Closed
ang-zeyu opened this issue Jul 31, 2022 · 1 comment · Fixed by #2000
Closed

Minimal panel button wrapper is on the next line #1979

ang-zeyu opened this issue Jul 31, 2022 · 1 comment · Fixed by #2000

Comments

@ang-zeyu
Copy link
Contributor

Please confirm that you have searched existing issues in the repo

Yes, I have searched the existing issues

Any related issues?

No response

Tell us about your environment

Anything

MarkBind version

4.0

What did you do? Describe the bug

Untitled

Probably a regression from: #1694

In particular:

Steps to reproduce

No response

Expected behavior

No response

Actual behavior

No response

Anything else?

No response

@jonahtanjz
Copy link
Contributor

(cc @jonahtanjz for context on what it was trying to solve if any, we should try to preserve both desired behaviours)

I think it was because display: inline-block was shifted from the .button-wrapper class in NestedPanel.vue to the .glyphicon class but since the glyphicon css already has the rule, we decided to remove it and forgot to shift the inline-block back to .button-wrapper.

Thanks for the catch @ang-zeyu :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants