Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade floating-vue to 1.0.0-beta.14 #1999

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

jonahtanjz
Copy link
Contributor

@jonahtanjz jonahtanjz commented Aug 10, 2022

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Overview of changes:
Fixes #1969
Fixes #1985

The newer versions of floating-vue cause the above issues. Downgrading to 1.0.0-beta.14 fixes the issues.

Anything you'd like to highlight/discuss:
NIL

Testing instructions:

  1. Go to https://deploy-preview-1999--markbind-master.netlify.app/devguide/design/projectstructure and hover over monorepo.
  2. Click on the link in the tooltip
  3. Untidy tail should also be resolved

Proposed commit message: (wrap lines at 72 characters)
Downgrade floating-vue to exact version 1.0.0-beta.14

The newer versions of floating-vue have issues with clickable
links and untidy tail in tooltips.

Let's downgrade floating-vue to exactly 1.0.0-beta.14 to
resolve the issues.


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

@jonahtanjz jonahtanjz requested a review from tlylt August 10, 2022 04:20
Copy link
Contributor

@tlylt tlylt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonahtanjz, LGTM!

@tlylt tlylt added this to the 4.0.1 milestone Aug 10, 2022
@tlylt
Copy link
Contributor

tlylt commented Aug 10, 2022

@jonahtanjz wonder if we should do a patch release for this?

@jonahtanjz
Copy link
Contributor Author

@jonahtanjz wonder if we should do a patch release for this?

Yup. Let's try to fix #1979 as well for the patch release. I will open up a PR soon for that.

@jonahtanjz jonahtanjz merged commit 708f3a5 into MarkBind:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clickable links no longer working in Tooltip Untidy tail in tooltips/popovers
2 participants