Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor methods implemented using Site.prototype #2280

Closed
jovyntls opened this issue Apr 15, 2023 · 0 comments · Fixed by #2356
Closed

Refactor methods implemented using Site.prototype #2280

jovyntls opened this issue Apr 15, 2023 · 0 comments · Fixed by #2356

Comments

@jovyntls
Copy link
Contributor

jovyntls commented Apr 15, 2023

Please confirm that you have searched existing issues in the repo

Yes, I have searched the existing issues

Is your feature request related to a problem? Please describe.

Currently, we implement a few methods using Site.prototype (here) due to incompatibility with ES6 class syntax.
This is slightly confusing, especially since we need to stub out the method signatures to maintain TS compatibility.

Describe the solution you'd like

If it is possible, let's implement these as class methods for consistency and readability.

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants