Show pointer and use underline dashed for click trigger #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A regression from MarkBind#1033 Let's add back the two styles of triggers: - click: show mouse pointer to signal that it is clickable and use underline dashed - not click: no special cursor, and use underline dotted
|
Seems to work fine 👍 Might be good to change the |
ang-zeyu
approved these changes
Mar 26, 2020
There was a problem hiding this comment.
LGTM 👍
do resolve the minor test file conflict though! @openorclose
Tejas2805
added a commit
to Tejas2805/markbind
that referenced
this pull request
Mar 28, 2020
…bind into remove-fixed-bugs * 'remove-fixed-bugs' of https://github.com/Tejas2805/markbind: Docs: Add contributing.md (MarkBind#1139) Show pointer and use underline dashed for click trigger (MarkBind#1111) Support variables to be defined as by JSON (MarkBind#1117) Allow an array for specifying page src or glob (MarkBind#1118) Code blocks: Implement inline markdown support for heading (MarkBind#1137) Fix lazy reload for urls without index (MarkBind#1110) Changes remaining references from filterTags to tags (MarkBind#1149)
marvinchin
pushed a commit
that referenced
this pull request
Apr 10, 2020
Fix a regression from #1033. Let's add back the two styles of triggers: - click: show mouse pointer to signal that it is clickable and use underline dashed - not click: no special cursor, and use underline dotted
|
@openorclose this doesn't seem to be working in the latest release. This hover tooltip is shown as a dashed underline (should be a dotted underline?)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Bug fix
Fixes #1053
What is the rationale for this request?
Regression from #1033, the migration to bootstrap-vue.
There were two styles for triggers depending on if it was a
clicktrigger or not.During the migration, only one style was used for all triggers.
What changes did you make? (Give an overview)
Implemented the two different styles depending on type of trigger.
Provide some example code that this change will affect:
Is there anything you'd like reviewers to focus on?
Testing instructions:
Check that click triggers have the proper style
Proposed commit message: (wrap lines at 72 characters)