Changes remaining references from filterTags to tags #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some existing references to filterTags.mbdf in the user guide. Let's change them to tabs.mbdf instead.
|
Sorry for missing these out. |
No worries, it happens. Our builds really should be failing hard for these errors. Hopefully the team can invest some time in improving our tooling soon :) Something wonky seems to be happening with Travis, will look at it. |
Tejas2805
added a commit
to Tejas2805/markbind
that referenced
this pull request
Mar 27, 2020
* 'master' of https://github.com/MarkBind/markbind: Fix lazy reload for urls without index (MarkBind#1110) Changes remaining references from filterTags to tags (MarkBind#1149)
Tejas2805
added a commit
to Tejas2805/markbind
that referenced
this pull request
Mar 28, 2020
…bind into remove-fixed-bugs * 'remove-fixed-bugs' of https://github.com/Tejas2805/markbind: Docs: Add contributing.md (MarkBind#1139) Show pointer and use underline dashed for click trigger (MarkBind#1111) Support variables to be defined as by JSON (MarkBind#1117) Allow an array for specifying page src or glob (MarkBind#1118) Code blocks: Implement inline markdown support for heading (MarkBind#1137) Fix lazy reload for urls without index (MarkBind#1110) Changes remaining references from filterTags to tags (MarkBind#1149)
marvinchin
pushed a commit
that referenced
this pull request
Apr 10, 2020
There are some existing references to filterTags.mbdf in the user guide. Let's change them to tabs.mbdf instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Bug fix
What is the rationale for this request?
When we changed
filterTags.mbdf->tags.mbdf, we missed some references to that file in other pages. This causes the documentation site to fail to build.What changes did you make? (Give an overview)
Fix the references to
filterTags.mbdfTesting instructions:
markbind serve docsshould workProposed commit message: (wrap lines at 72 characters)
There are some existing references to filterTags.mbdf in the user guide. Let's
change them to tabs.mbdf instead.