Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fixed bugs from test\functional\test_site\bugs\index.md` #1148

Merged
merged 18 commits into from
Apr 2, 2020
Merged

Remove fixed bugs from test\functional\test_site\bugs\index.md` #1148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
538ff88
add _site to ignore list
Tejas2805 Feb 16, 2020
52e1afa
update highlighted text bg color
Tejas2805 Feb 17, 2020
f3d3f34
Merge branch 'master' of https://github.com/MarkBind/markbind
Tejas2805 Feb 27, 2020
31d0325
Merge branch 'master' of https://github.com/MarkBind/markbind
Tejas2805 Mar 9, 2020
d86bf69
Merge branch 'master' of https://github.com/MarkBind/markbind
Tejas2805 Mar 15, 2020
22b2b74
Merge branch 'master' of https://github.com/MarkBind/markbind
Tejas2805 Mar 21, 2020
5d20611
Merge branch 'master' of https://github.com/MarkBind/markbind
Tejas2805 Mar 23, 2020
60a44fa
Merge branch 'master' of https://github.com/MarkBind/markbind
Tejas2805 Mar 25, 2020
c493dbe
remove fixed bugs
Tejas2805 Mar 25, 2020
a752205
add test file for modals
Tejas2805 Mar 25, 2020
5f9b019
add test for second bug
Tejas2805 Mar 25, 2020
a16f0bc
change functional testing description
Tejas2805 Mar 26, 2020
776ff9c
update test
Tejas2805 Mar 26, 2020
edb57c7
add html pages for new functional tests
Tejas2805 Mar 27, 2020
6795536
Merge branch 'master' into remove-fixed-bugs
Tejas2805 Mar 28, 2020
f206f35
update
Tejas2805 Mar 28, 2020
422e202
Merge branch 'remove-fixed-bugs' of https://github.com/Tejas2805/mark…
Tejas2805 Mar 28, 2020
6fd6606
Update testPopoverTrigger.html
Tejas2805 Mar 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 3 additions & 27 deletions test/functional/test_site/bugs/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,36 +5,12 @@ header: header.md

<div class="website-content">

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we now have an empty bugs file 🎉

Should we leave a comment here so that future contributors know what this file is for, and where to place their bugs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should probably be something like a template:

**Bug Description**
<a href=LINK_TO_MARKBIND_ISSUE>Issue #XX</a>

Repro:

Repro Steps...

**popover initiated by trigger: honor trigger attribute**
**Bug Description**

<a href="https://github.com/MarkBind/markbind/issues/49">Issue #49</a>
<a href=LINK_TO_MARKBIND_ISSUE>Issue #XX</a>

Repro:

<trigger for="pop:xp-user-stories">Establishing Requirements</trigger>

<popover id="pop:xp-user-stories" trigger="click">
<div slot="content">
<include src="../requirements/EstablishingRequirements.md#preview" />
</div>
</popover>

**Support multiple inclusions of a modal**

<a href="https://github.com/MarkBind/markbind/issues/107">Issue #107</a>

Repro:

<include src="modal.md" />
<include src="modal.md" />

**Remove extra space in links**

<a href="https://github.com/MarkBind/markbind/issues/147">Issue #147</a>

Repro:

This is a link.
[[link text](https://github.com)]
Steps to Reproduce

</div>
5 changes: 0 additions & 5 deletions test/functional/test_site/bugs/modal.md
View file
Open in desktop

This file was deleted.

40 changes: 3 additions & 37 deletions test/functional/test_site/expected/bugs/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,44 +35,10 @@
<div id="flex-body">
<div id="content-wrapper">
<div class="website-content">
<p><strong>popover initiated by trigger: honor trigger attribute</strong></p>
<p><a href="https://github.com/MarkBind/markbind/issues/49">Issue #49</a></p>
<p><strong>Bug Description</strong></p>
<p><a href="/test_site/bugs/LINK_TO_MARKBIND_ISSUE">Issue #XX</a></p>
<p>Repro:</p>
<p><span for="pop:xp-user-stories" v-b-popover.hover.top.html="popoverGenerator" v-b-tooltip.hover.top.html="tooltipContentGetter" v-on:mouseover="$refs['pop:xp-user-stories'].show()" class="trigger">Establishing Requirements</span></p>
<span id="pop:xp-user-stories" trigger="click" data-mb-component-type="popover" v-b-popover.click.top.html="popoverInnerGenerator" class="trigger-click">
<div data-mb-html-for="content">
<div>
<p>Requirements gathering, requirements elicitation, requirements analysis,
requirements capture are some of the terms commonly <strong>and</strong> interchangeably used to represent the activity
of understanding what a software product should do.</p></div></div></span>
<p><strong>Support multiple inclusions of a modal</strong></p>
<p><a href="https://github.com/MarkBind/markbind/issues/107">Issue #107</a></p>
<p>Repro:</p>
<div>
<p>This is to reproduce <span trigger="click" for="modal:bugRepro" v-b-popover.click.top.html="popoverGenerator" v-b-tooltip.click.top.html="tooltipContentGetter" v-on:click="$refs['modal:bugRepro'].show()" class="trigger-click">multiple inclusions of a modal bug</span></p>
<b-modal id="modal:bugRepro" hide-footer="" size="lg" modal-class="mb-zoom" ref="modal:bugRepro"><template slot="modal-title">Establishing Requirements</template>
<div>
<p>Requirements gathering, requirements elicitation, requirements analysis, requirements capture are some of the terms commonly <strong>and</strong> interchangeably used to represent the activity of understanding what a software product should
do.
</p>
</div>
</b-modal>
</div>
<div>
<p>This is to reproduce <span trigger="click" for="modal:bugRepro" v-b-popover.click.top.html="popoverGenerator" v-b-tooltip.click.top.html="tooltipContentGetter" v-on:click="$refs['modal:bugRepro'].show()" class="trigger-click">multiple inclusions of a modal bug</span></p>
<b-modal id="modal:bugRepro" hide-footer="" size="lg" modal-class="mb-zoom" ref="modal:bugRepro"><template slot="modal-title">Establishing Requirements</template>
<div>
<p>Requirements gathering, requirements elicitation, requirements analysis, requirements capture are some of the terms commonly <strong>and</strong> interchangeably used to represent the activity of understanding what a software product should
do.
</p>
</div>
</b-modal>
</div>
<p><strong>Remove extra space in links</strong></p>
<p><a href="https://github.com/MarkBind/markbind/issues/147">Issue #147</a></p>
<p>Repro:</p>
<p>This is a link. [
<a href="https://github.com">link text</a>]</p>
<p>Steps to Reproduce</p>
</div>
</div>
</div>
Expand Down
18 changes: 18 additions & 0 deletions test/functional/test_site/expected/siteData.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,24 @@
"globalAndFrontMatterOverrideProperty": "Overridden by global override",
"headings": {},
"headingKeywords": {}
},
{
"src": "testIncludeMultipleModals.md",
"title": "Multiple inclusions of a modal should be supported",
"layout": "default",
"globalOverrideProperty": "Overridden by global override",
"globalAndFrontMatterOverrideProperty": "Overridden by global override",
"headings": {},
"headingKeywords": {}
},
{
"src": "testPopoverTrigger.md",
"title": "Popover initiated by trigger should honor trigger attribute",
"layout": "default",
"globalOverrideProperty": "Overridden by global override",
"globalAndFrontMatterOverrideProperty": "Overridden by global override",
"headings": {},
"headingKeywords": {}
}
]
}
85 changes: 85 additions & 0 deletions test/functional/test_site/expected/testIncludeMultipleModals.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
<!DOCTYPE html>
<html>

<head>
<meta name="default-head-top">
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="generator" content="MarkBind 2.12.0">
<meta name="viewport" content="width=device-width, initial-scale=1">
<title>Multiple inclusions of a modal should be supported</title>
<link rel="stylesheet" href="markbind/css/bootstrap.min.css">
<link rel="stylesheet" href="markbind/css/bootstrap-vue.min.css">
<link rel="stylesheet" href="markbind/fontawesome/css/all.min.css">
<link rel="stylesheet" href="markbind/glyphicons/css/bootstrap-glyphicons.min.css">
<link rel="stylesheet" href="markbind/css/octicons.css">
<link rel="stylesheet" href="markbind/css/github.min.css">
<link rel="stylesheet" href="markbind/css/markbind.css">
<link rel="stylesheet" href="STYLESHEET_LINK">
<link rel="stylesheet" href="markbind/layouts/default/styles.css">
<meta name="default-head-bottom">
<link rel="icon" href="/test_site/favicon.png">
</head>

<body>
<div id="app">
<div id="flex-body">
<div id="content-wrapper">
<p><strong>Multiple inclusions of a modal should be supported</strong></p>
<div>

<b-modal id="modal:bugRepro" hide-footer="" size="lg" modal-class="mb-zoom" ref="modal:bugRepro"><template slot="modal-title">Establishing Requirements</template>
<div>
<p>Requirements gathering, requirements elicitation, requirements analysis, requirements capture are some of the terms commonly <strong>and</strong> interchangeably used to represent the activity of understanding what a software product should
do.</p>
</div>
</b-modal>
</div>
<div>

<b-modal id="modal:bugRepro" hide-footer="" size="lg" modal-class="mb-zoom" ref="modal:bugRepro"><template slot="modal-title">Establishing Requirements</template>
<div>
<p>Requirements gathering, requirements elicitation, requirements analysis, requirements capture are some of the terms commonly <strong>and</strong> interchangeably used to represent the activity of understanding what a software product should
do.</p>
</div>
</b-modal>
</div>
</div>
</div>
<footer>
<div class="text-center">
Default footer
</div>
</footer>
</div>
</body>
<script src="markbind/js/vue.min.js"></script>
<script src="markbind/js/vue-strap.min.js"></script>
<script src="markbind/js/bootstrap-utility.min.js"></script>
<script src="markbind/js/polyfill.min.js"></script>
<script src="markbind/js/bootstrap-vue.min.js"></script>
<script>
const baseUrl = '/test_site'
const enableSearch = true
</script>
<script src="markbind/js/setup.js"></script>
<script src="SCRIPT_LINK"></script>
<script>
alert("hello")
</script>

<!-- Global site tag (gtag.js) - Google Analytics -->
<script async src="https://www.googletagmanager.com/gtag/js?id=TRACKING-ID"></script>
<script>
window.dataLayer = window.dataLayer || [];

function gtag() {
dataLayer.push(arguments);
}
gtag('js', new Date());

gtag('config', 'TRACKING-ID');
</script>
<script src="markbind/layouts/default/scripts.js"></script>

</html>
71 changes: 71 additions & 0 deletions test/functional/test_site/expected/testPopoverTrigger.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
<!DOCTYPE html>
<html>

<head>
<meta name="default-head-top">
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="generator" content="MarkBind 2.12.0">
<meta name="viewport" content="width=device-width, initial-scale=1">
<title>Popover initiated by trigger should honor trigger attribute</title>
<link rel="stylesheet" href="markbind/css/bootstrap.min.css">
<link rel="stylesheet" href="markbind/css/bootstrap-vue.min.css">
<link rel="stylesheet" href="markbind/fontawesome/css/all.min.css">
<link rel="stylesheet" href="markbind/glyphicons/css/bootstrap-glyphicons.min.css">
<link rel="stylesheet" href="markbind/css/octicons.css">
<link rel="stylesheet" href="markbind/css/github.min.css">
<link rel="stylesheet" href="markbind/css/markbind.css">
<link rel="stylesheet" href="STYLESHEET_LINK">
<link rel="stylesheet" href="markbind/layouts/default/styles.css">
<meta name="default-head-bottom">
<link rel="icon" href="/test_site/favicon.png">
</head>

<body>
<div id="app">
<div id="flex-body">
<div id="content-wrapper">
<p><strong>Popover initiated by trigger should honor trigger attribute</strong></p>
<span id="pop:xp-user-stories" trigger="click" data-mb-component-type="popover" v-b-popover.click.top.html="popoverInnerGenerator" class="trigger-click">
popover
<div data-mb-html-for="content">
User stories
</div></span></div>
</div>
<footer>
<div class="text-center">
Default footer
</div>
</footer>
</div>
</body>
<script src="markbind/js/vue.min.js"></script>
<script src="markbind/js/vue-strap.min.js"></script>
<script src="markbind/js/bootstrap-utility.min.js"></script>
<script src="markbind/js/polyfill.min.js"></script>
<script src="markbind/js/bootstrap-vue.min.js"></script>
<script>
const baseUrl = '/test_site'
const enableSearch = true
</script>
<script src="markbind/js/setup.js"></script>
<script src="SCRIPT_LINK"></script>
<script>
alert("hello")
</script>

<!-- Global site tag (gtag.js) - Google Analytics -->
<script async src="https://www.googletagmanager.com/gtag/js?id=TRACKING-ID"></script>
<script>
window.dataLayer = window.dataLayer || [];

function gtag() {
dataLayer.push(arguments);
}
gtag('js', new Date());

gtag('config', 'TRACKING-ID');
</script>
<script src="markbind/layouts/default/scripts.js"></script>

</html>
5 changes: 5 additions & 0 deletions test/functional/test_site/requirements/testModal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<!-- Used in test_site/testIncludeMultipleModals.md---->

<modal large header="Establishing Requirements" id="modal:bugRepro">
<include src="EstablishingRequirements.md#preview"/>
</modal>
8 changes: 8 additions & 0 deletions test/functional/test_site/site.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,14 @@
{
"src": "testIncludePluginsRendered.md",
"title": "Included files should have plugins rendered on them"
},
{
"src": "testIncludeMultipleModals.md",
"title": "Multiple inclusions of a modal should be supported"
},
{
"src": "testPopoverTrigger.md",
"title": "Popover initiated by trigger should honor trigger attribute"
}
],
"ignore": [
Expand Down
4 changes: 4 additions & 0 deletions test/functional/test_site/testIncludeMultipleModals.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
**Multiple inclusions of a modal should be supported**

<include src="requirements/testModal.md" />
<include src="requirements/testModal.md" />
8 changes: 8 additions & 0 deletions test/functional/test_site/testPopoverTrigger.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
**Popover initiated by trigger should honor trigger attribute**

<popover id="pop:xp-user-stories" trigger="click">
popover
<div slot="content">
User stories
</div>
</popover>