Remove fixed bugs from test\functional\test_site\bugs\index.md` #1148

Tejas2805 · 2020-03-25T15:01:01Z

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Other, please explain:
The test\functional\test_site\bugs\index.md file has some bugs listed which have already been fixed already. Let's remove them.

Fixes #1140

What is the rationale for this request?
Some bugs in the open bugs page have already been fixed. Therefore I would be good to tidy up and remove fixed bugs from test\functional\test_site\bugs\index.md
In order to make sure that these we do not regress and have these bugs again, add these cases as tests in appropriate test_site markdown files, or create new markdown files if nothing suitable is present.

What changes did you make? (Give an overview)

Added test file for the bugs fixed

Provide some example code that this change will affect:
N.A.

Is there anything you'd like reviewers to focus on?
Nothing specifically

Testing instructions:
N.A.

Proposed commit message: (wrap lines at 72 characters)

Some bugs in the open bugs page have been fixed already but they
are still present in the page.

Let's remove the fixed bugs from the open bugs page.  

Let's also add a test case for these bugs, if not added already, 
in the appropriate test_site markdown files. This will ensure 
we don't regress and have these bugs again.

* 'master' of https://github.com/MarkBind/markbind: Update tests Allow using 'none' footer attribute in frontmatter (MarkBind#1002) Support line numbers for code blocks (MarkBind#991) 2.11.0 Update test files due to changes in PR MarkBind#982 Update vue-strap version to v2.0.1-markbind.36 Make highlighting bold (MarkBind#1045) Support markdown for header attr in dropdown (MarkBind#1029) Add '_site' to the ignored folders in site.json (MarkBind#1046) Use path.join instead of string interpolation (MarkBind#1052) Implement box markdown header attributes parsing (MarkBind#1025) Make the position of top navbar fixed (MarkBind#982) Exclude *.md files from being copied over on build (MarkBind#1010) # Conflicts: # docs/css/main.css

* 'master' of https://github.com/MarkBind/markbind: 2.12.0 Update outdated test files Update vue-strap version to v2.0.1-markbind.37 Fix refactor to processDynamicResources (MarkBind#1092) Implement lazy page building for markbind serve (MarkBind#1038) Add warnings for conflicting/deprecated component attribs (MarkBind#1057) Allow changing parameter properties (MarkBind#1075) Custom timezone for built-in timestamp (MarkBind#1073) Fix reload inconsistency when updating frontmatter (MarkBind#1068) Implement an api to ignore content in certain tags (MarkBind#1047) Enable AppVeyor CI (MarkBind#1040) Add heading and line highlighting to code blocks (MarkBind#1034) Add dividers and fix bug in siteNav (MarkBind#1063) Fixed navbar no longer covers modals (MarkBind#1070) Add copy code-block plugin (MarkBind#1043) Render plugins on dynamic resources (MarkBind#1051) Documentation for Implement no-* attributes for <box> (MarkBind#1042) Migrate to bootstrap-vue popovers (MarkBind#1033) Refactor preprocess and url processing functions (MarkBind#1026) Add pageNav to Using Plugins Page (MarkBind#1062)

* 'master' of https://github.com/MarkBind/markbind: Add example for using multiple features in code-blocks (MarkBind#1102)

* 'master' of https://github.com/MarkBind/markbind: Convert code in boxes to code block (MarkBind#1086)

* 'master' of https://github.com/MarkBind/markbind: Update test files (MarkBind#1138) Remove OK button from modals (MarkBind#1134) Add start from line number functionality to code blocks (MarkBind#1115) Allow special tags to be self-closing (MarkBind#1101) Simplify baseUrl resolving process (MarkBind#1087) Remove redundant file writing (MarkBind#1090) Bump acorn from 5.7.3 to 5.7.4 (MarkBind#1121) Bump acorn from 7.1.0 to 7.1.1 in /src/lib/markbind (MarkBind#1120) Unify markdown-it parser variants (MarkBind#1056) Remove dynamic include feature (MarkBind#1037) Fix flex shrink not applying in content wrapper (MarkBind#1135) Escape Nunjucks for special tags (MarkBind#1049) Update documentation on icon slot for boxes (MarkBind#1123)

* 'master' of https://github.com/MarkBind/markbind: Fix pageNav in tweaking the page structure (MarkBind#1127)

Tejas2805 · 2020-03-25T15:01:38Z

@nbriannl The last issue was closed but hasn't been fixed. Should I keep it or remove it?

nbriannl · 2020-03-25T15:16:42Z

@Tejas2805 Which one?

Tejas2805 · 2020-03-25T15:17:36Z

The one which I didn't remove - #147

nbriannl · 2020-03-25T15:22:18Z

@Tejas2805 In my opinion, i think you can remove it.

And since the issue is closed, and we've pretty much given up to solve it, this bug is considered closed. It seems that there's corresponding documentation informing users about this. So we're alright on that end.

Oh, and could you check if these behaviors have a corresponding test in any of the test site files?

I was thinking, instead of removing, I think it would be more suitable to move them to the corresponding test files. If there isn't any existing test file covering the related feature, then you can create a new one.

Tejas2805 · 2020-03-25T19:26:36Z

@nbriannl Did you have something like this in mind?

nbriannl

Yes. What I had in mind. Having looked through other test files, functional testing description should be phrased as an ability to achieve something i.e. '... should be ... ', ' should still' etc.

I gave my suggestions below.

nbriannl · 2020-03-26T04:05:17Z

test/functional/test_site/testIncludeMultipleModals.md

@@ -0,0 +1,4 @@
+**Support Multiple Modals**


'Multiple inclusions of a modal should be supported'

test/functional/test_site/requirements/createModal.md

nbriannl · 2020-03-26T04:08:10Z

test/functional/test_site/testTriggerAttributeHonor.md

@@ -0,0 +1,8 @@
+**Test Trigger Attribute is Honored**


Perhaps 'Popover initiated by trigger should honor trigger attribute'

Tejas2805 · 2020-03-26T14:18:29Z

Btw how to generate the corresponding HTML files?

npm run updatetest or npm run updatetestwin

Tejas2805 · 2020-03-26T15:43:04Z

@nbriannl I tried running the commands. But no new files were created. Only the old ones got updated

Tejas2805 · 2020-03-26T15:46:47Z

@marvinchin Need your review on this.

nbriannl · 2020-03-27T04:15:47Z

@nbriannl I tried running the commands. But no new files were created. Only the old ones got updated

I see, my bad. I guess we need documentation regarding updating tests.

Open test\functional\test_site\site.json
To include a new page, eg: testIncludeMultipleModals.md, add it to the pages array.

"pages": [
    {
      "src": "index.md",
      "title": "Hello World",
      "frontmatter": {
        "frontMatterOverrideProperty": "Overridden by front matter override",
        "globalAndFrontMatterOverrideProperty":  "Overridden by front matter override"
      }
    },
    ...
    {
      "src": "testLayouts.md",
      "title": "Hello World"
    },
    {,
      "src": "testIncludeMultipleModals.md",
      "title": [some title you see fit]
    },
    ....

Then you should be able to update test sites.

And just an advice, you can ping marvin via the top right reviewers section as well. 🙂

Tejas2805 · 2020-03-27T09:40:41Z

And just an advice, you can ping marvin via the top right reviewers section as well. 🙂

Don't seem to have access to do that. This is why have to tag him everytime

Tejas2805 · 2020-03-27T09:41:34Z

I guess we need documentation regarding updating tests.

Want me to do it in Separate PR or can do in this one?

nbriannl · 2020-03-27T09:46:08Z

Don't seem to have access to do that. This is why have to tag him everytime

Oh! Today i learned, sorry for the misunderstanding. 😞

Want me to do it in Separate PR or can do in this one?

A separate PR (an issue) would be better.

marvinchin

Thanks for cleaning this up, it mostly looks good to me! Just some minor nits.

Also, sorry I didn't realise you didn't have permissions to request reviews! Let me look at this 🙏

marvinchin · 2020-03-28T06:09:51Z

test/functional/test_site/bugs/index.md

@@ -4,37 +4,4 @@ header: header.md
 </frontmatter>

 <div class="website-content">
-


It seems like we now have an empty bugs file 🎉

Should we leave a comment here so that future contributors know what this file is for, and where to place their bugs?

It should probably be something like a template:

**Bug Description** <a href=LINK_TO_MARKBIND_ISSUE>Issue #XX</a> Repro: Repro Steps...

marvinchin · 2020-03-28T06:10:41Z

test/functional/test_site/testTriggerAttributeHonor.md

@@ -0,0 +1,8 @@
+**Popover initiated by trigger should honor trigger attribute**


This is definitely just a nit, but testTriggerAttributeHonor.md sounds a little odd to me. What do you think of testTriggerAttributeHonor.md -> testPopoverTrigger.md?

Ya, agreed. Makes sense

marvinchin · 2020-03-28T06:11:30Z

test/functional/test_site/requirements/createModal.md

@@ -0,0 +1,5 @@
+<!-- Used in test_site/testIncludeMultipleModals.md---->


createModal.md sounds a little misleading here, since this isn't a function that creates a modal or anything like that. Shall we just name this testModal.md?

…bind into remove-fixed-bugs * 'remove-fixed-bugs' of https://github.com/Tejas2805/markbind: Docs: Add contributing.md (MarkBind#1139) Show pointer and use underline dashed for click trigger (MarkBind#1111) Support variables to be defined as by JSON (MarkBind#1117) Allow an array for specifying page src or glob (MarkBind#1118) Code blocks: Implement inline markdown support for heading (MarkBind#1137) Fix lazy reload for urls without index (MarkBind#1110) Changes remaining references from filterTags to tags (MarkBind#1149)

Tejas2805 · 2020-03-30T09:11:38Z

@nbriannl @marvinchin Need your reviews on this.

nbriannl

LGTM

nbriannl · 2020-04-01T09:11:00Z

Hi @Tejas2805 do you mind to put a commit message for this PR. I'll have a look at it one more time. 🙂

Tejas2805 · 2020-04-01T09:34:04Z

@nbriannl Done!

nbriannl · 2020-04-01T10:00:22Z

LGTM once more. You addressed all of @marvinchin's comment. I'll leave it until tmr morning for any dev to comment on this, then i'll merge.

marvinchin

LGTM 🚀

* 'master' of https://github.com/MarkBind/markbind: (41 commits) Document adding new site content in DG (MarkBind#1153) Add relative date feature (MarkBind#908) Use <br> to separate lines of code block (MarkBind#1176) Parse popovers for footnotes (MarkBind#1155) Resolve comments Expand test extensions and fix whitespace checks (MarkBind#1156) Address comments Upgrade js-beautify and provide option to turn it off (MarkBind#1116) Normalize inline puml line ending before hashing (MarkBind#1174) Update tests (MarkBind#1178) Remove fixed bugs from test\functional\test_site\bugs\index.md` (MarkBind#1148) Fix bug in Search for UG and DG (MarkBind#1147) Add inline puml support (MarkBind#1100) Fix hrefs for headings with angular brackets (MarkBind#1089) Update tests for 2.13.1 (MarkBind#1169) 2.13.1 Update vue-strap version to v2.0.1-markbind.39 Fix fontawsome icons don't show underlines to indicate modal/tooltip (MarkBind#1133) 2.13.0 Update test files ...

Tejas2805 added 9 commits February 17, 2020 04:54

add _site to ignore list

538ff88

update highlighted text bg color

52e1afa

Merge branch 'master' of https://github.com/MarkBind/markbind

d86bf69

* 'master' of https://github.com/MarkBind/markbind: Add example for using multiple features in code-blocks (MarkBind#1102)

Merge branch 'master' of https://github.com/MarkBind/markbind

22b2b74

* 'master' of https://github.com/MarkBind/markbind: Convert code in boxes to code block (MarkBind#1086)

Merge branch 'master' of https://github.com/MarkBind/markbind

60a44fa

* 'master' of https://github.com/MarkBind/markbind: Fix pageNav in tweaking the page structure (MarkBind#1127)

remove fixed bugs

c493dbe

Tejas2805 added 2 commits March 26, 2020 03:08

add test file for modals

a752205

add test for second bug

5f9b019

nbriannl requested changes Mar 26, 2020

View reviewed changes

Tejas2805 added 2 commits March 26, 2020 22:51

change functional testing description

a16f0bc

update test

776ff9c

Tejas2805 requested a review from nbriannl March 26, 2020 15:42

add html pages for new functional tests

edb57c7

marvinchin requested changes Mar 28, 2020

View reviewed changes

Merge branch 'master' into remove-fixed-bugs

6795536

Tejas2805 and others added 3 commits March 29, 2020 06:35

update

f206f35

Update testPopoverTrigger.html

6fd6606

Tejas2805 requested a review from marvinchin March 30, 2020 09:11

nbriannl approved these changes Mar 31, 2020

View reviewed changes

nbriannl requested a review from ang-zeyu April 1, 2020 09:05

nbriannl added the pr.CodeMaintenance 🛠 DevOps, refactoring, etc label Apr 1, 2020

marvinchin approved these changes Apr 2, 2020

View reviewed changes

marvinchin added this to the v2.13.2 milestone Apr 2, 2020

marvinchin merged commit 7ec7bc4 into MarkBind:master Apr 2, 2020

marvinchin pushed a commit that referenced this pull request Apr 10, 2020

Remove fixed bugs from test\functional\test_site\bugs\index.md` (#1148)

b02f065

Tejas2805 deleted the remove-fixed-bugs branch April 11, 2020 14:07

tlylt mentioned this pull request Aug 8, 2021

Add/fix documentation for usage of open bugs page under test/functional/test_site/bugs #1644

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove fixed bugs from test\functional\test_site\bugs\index.md` #1148

Remove fixed bugs from test\functional\test_site\bugs\index.md` #1148

Tejas2805 commented Mar 25, 2020 •

edited

Loading

Tejas2805 commented Mar 25, 2020

nbriannl commented Mar 25, 2020

Tejas2805 commented Mar 25, 2020

nbriannl commented Mar 25, 2020 •

edited

Loading

Tejas2805 commented Mar 25, 2020

nbriannl left a comment

nbriannl Mar 26, 2020

nbriannl Mar 26, 2020

Tejas2805 commented Mar 26, 2020 •

edited by nbriannl

Loading

Tejas2805 commented Mar 26, 2020

Tejas2805 commented Mar 26, 2020

nbriannl commented Mar 27, 2020 •

edited

Loading

Tejas2805 commented Mar 27, 2020

Tejas2805 commented Mar 27, 2020

nbriannl commented Mar 27, 2020

marvinchin left a comment •

edited

Loading

marvinchin Mar 28, 2020

marvinchin Mar 28, 2020

marvinchin Mar 28, 2020

Tejas2805 Mar 28, 2020

marvinchin Mar 28, 2020

Tejas2805 Mar 28, 2020

Tejas2805 commented Mar 30, 2020

nbriannl left a comment

nbriannl commented Apr 1, 2020 •

edited

Loading

Tejas2805 commented Apr 1, 2020

nbriannl commented Apr 1, 2020

marvinchin left a comment

		@@ -4,37 +4,4 @@ header: header.md
		</frontmatter>

		<div class="website-content">

		@@ -0,0 +1,8 @@
		Popover initiated by trigger should honor trigger attribute

		@@ -0,0 +1,5 @@
		<!-- Used in test_site/testIncludeMultipleModals.md---->

Remove fixed bugs from test\functional\test_site\bugs\index.md` #1148

Remove fixed bugs from test\functional\test_site\bugs\index.md` #1148

Conversation

Tejas2805 commented Mar 25, 2020 • edited Loading

Tejas2805 commented Mar 25, 2020

nbriannl commented Mar 25, 2020

Tejas2805 commented Mar 25, 2020

nbriannl commented Mar 25, 2020 • edited Loading

Tejas2805 commented Mar 25, 2020

nbriannl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tejas2805 commented Mar 26, 2020 • edited by nbriannl Loading

Tejas2805 commented Mar 26, 2020

Tejas2805 commented Mar 26, 2020

nbriannl commented Mar 27, 2020 • edited Loading

Tejas2805 commented Mar 27, 2020

Tejas2805 commented Mar 27, 2020

nbriannl commented Mar 27, 2020

marvinchin left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tejas2805 commented Mar 30, 2020

nbriannl left a comment

Choose a reason for hiding this comment

nbriannl commented Apr 1, 2020 • edited Loading

Tejas2805 commented Apr 1, 2020

nbriannl commented Apr 1, 2020

marvinchin left a comment

Choose a reason for hiding this comment

Tejas2805 commented Mar 25, 2020 •

edited

Loading

nbriannl commented Mar 25, 2020 •

edited

Loading

Tejas2805 commented Mar 26, 2020 •

edited by nbriannl

Loading

nbriannl commented Mar 27, 2020 •

edited

Loading

marvinchin left a comment •

edited

Loading

nbriannl commented Apr 1, 2020 •

edited

Loading