-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardise code style and remove eslint disables #1180
Conversation
I don't think we should need to go in and manually fix styling? If it's accepted by eslint, that should be good enough. Too much time will be spent on commenting about code style in PRs otherwise. That being said, it's good that some of the unnecessary eslint disables are removed. |
Most of the style regressions were rather awkward, you could refer here #979 (review)
Yes, this PR is specifically made for reverting the unintended code style changes though 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the cleanup looks pretty good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rebase your PR 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Other, please explain:
What is the rationale for this request?
eslint-disable-xx
'sWhat changes did you make? (Give an overview)
Example of style regression fixed
Is there anything you'd like reviewers to focus on?
na
Testing instructions:
na
Proposed commit message: (wrap lines at 72 characters)
Standardise code style and remove eslint disables