Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Guide: Update members in About Us #1186

Merged
merged 1 commit into from
Apr 11, 2020

Conversation

nbriannl
Copy link
Contributor

@nbriannl nbriannl commented Apr 10, 2020

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Documentation update

Fixes #1171

What is the rationale for this request?

What changes did you make? (Give an overview)
Added new members, added inactive members, added contributors, promoted someone into a mentor.

Is there anything you'd like reviewers to focus on?
Testing instructions:

View the page at
https://deploy-preview-1186--markbind-master.netlify.com/about.html
Anyone I'm missing out? Incorrect info?

Proposed commit message: (wrap lines at 72 characters)

User Guide: Update members in About Us

Copy link
Contributor

@damithc damithc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick comments

docs/about.md Outdated Show resolved Hide resolved
docs/about.md Outdated Show resolved Hide resolved
docs/about.md Show resolved Hide resolved
Copy link
Contributor

@yash-chowdhary yash-chowdhary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just a few nits

docs/about.md Show resolved Hide resolved
docs/about.md Outdated Show resolved Hide resolved
docs/about.md Outdated Show resolved Hide resolved
docs/about.md Outdated Show resolved Hide resolved
docs/about.md Show resolved Hide resolved
@nbriannl nbriannl merged commit 2c2c43c into MarkBind:master Apr 11, 2020
@nbriannl nbriannl added this to the v2.13.2 milestone Apr 13, 2020
@nbriannl nbriannl deleted the team-update branch April 16, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Guide: Update members in About Us
6 participants