Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix highlighting error #1209

Closed
wants to merge 1 commit into from
Closed

Fix highlighting error #1209

wants to merge 1 commit into from

Conversation

Tejas2805
Copy link
Contributor

@Tejas2805 Tejas2805 commented Apr 19, 2020 •
edited
Loading

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [ ] Bug fix

What is the rationale for this request?
The highlighting of the sentence is pretty weird.

Screen Shot 2020-04-19 at 9 04 07 PM

What changes did you make? (Give an overview)
Made the highlighting consistent

Provide some example code that this change will affect:
N.A.

Is there anything you'd like reviewers to focus on?
N.A.

Testing instructions:
Can check the deployed preview.

As of now,
Screen Shot 2020-04-19 at 9 06 36 PM

Proposed commit message: (wrap lines at 72 characters)

The page - Deploying the Site - has a sentence which
is not highlighted properly.

Let's fix the highlighting error and make it consistent
with rest of the page.

@Tejas2805 Tejas2805 changed the title fix highlighting Fix highlighting error Apr 19, 2020
@damithc damithc removed their request for review April 19, 2020 13:50
@damithc damithc mentioned this pull request Apr 19, 2020
Closed
@ang-zeyu ang-zeyu added this to the v2.15.0 milestone Apr 21, 2020
@le0tan le0tan mentioned this pull request Apr 22, 2020
Merged
@le0tan le0tan added the pr.DocsUpdate 📃 Pure changes to the documentation, such as typo, restructuring, etc label Apr 22, 2020
@le0tan
Copy link
Contributor

le0tan commented Apr 26, 2020

@Tejas2805 @ang-zeyu can I close this PR as it's fixed in #1215 ?

@ang-zeyu
Copy link
Contributor

ang-zeyu commented May 2, 2020

@Tejas2805 @ang-zeyu can I close this PR as it's fixed in #1215 ?

Yes think that's better

@ang-zeyu ang-zeyu removed this from the v2.15.0 milestone May 2, 2020
@le0tan
Copy link
Contributor

le0tan commented May 2, 2020

Closed in favor or #1215

@le0tan le0tan closed this May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ang-zeyu ang-zeyu ang-zeyu approved these changes

@marvinchin marvinchin Awaiting requested review from marvinchin

Assignees
No one assigned
Labels
pr.DocsUpdate 📃 Pure changes to the documentation, such as typo, restructuring, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tejas2805 @le0tan @ang-zeyu