-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak site navigation design #1222
Conversation
@damithc could I get your opinion on the tweaks here? *the pr currently makes clicking a dropdown that is also a link expand/collapse the dropdown (will be fixed) |
e5813f5
to
4032423
Compare
b091482
to
b60031b
Compare
@ang-zeyu We seem to have lost some of the flexibility we had before though. For example, it was possible to use normal HTML to tweak the appearance of the siteNav e.g., use |
not easily, the issue is that previously, the With the "box" this becomes an issue, as the whole There isn't a way afaik in markdown to insert content between the I could hardcode Instead, how about playing to the markdown spec and using another list item to insert custom content?
This works currently, but an extra "box" with highlight is created for the
|
We can try option 1. In that case, need to document that 'trick' in the user guide as it will not be obvious. Can create an issue and get to it later as it is not urgent (because old sites using rouge syntax is going to break anyway, even with that solution). |
Should be a pretty minor change, will lump it in with #1241 as well |
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Enhancement to an existing feature
Requires #1221 (simplifies / removes the recursive process so that the changes here make more sense)
What is the rationale for this request?
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
Testing instructions:
npm run test
should passProposed commit message: (wrap lines at 72 characters)
Redesign site navigation sidebar