Variable storing "Include" tags test cases #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxwxwxwx9
changed the title
ang-zeyu
reviewed
Aug 13, 2020
There was a problem hiding this comment.
thanks @wxwxwxwx9!
the puml png updates are a result of #1130, which we haven't found a way to workaround unfortunately. You can discard them as well (unless making changes to those png puml files)
Sorry, missed this out. Needs a commit message title (try to keep the title within 50 characters) A good read that @yamgent shared originally: https://chris.beams.io/posts/git-commit/ |
This reverts commit 979bad3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
• [X] Other, please explain:
Adding new test case for #735
What is the rationale for this request?
Adding a new test case to ensure that "variable" in Markbind can store "include" tags and output the content in the "include" reference properly.
What changes did you make? (Give an overview)
I have added a small unit test case to ensure that "variable" in Markbind can store "include" tags and output the content in the "include" reference properly.
Is there anything you'd like reviewers to focus on?
NIL
Testing instructions:
npm run testProposed commit message: (wrap lines at 72 characters)
Add test case to check variable outputs include properly
There are currently no test cases to test the feature where "variable"
can store "include" tags and output the content properly.
Let's add this test case to
test_site.