Change code fence html line break to newlines #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The codeBlockCopyButtons plugin relies on the textContent of the code fence html element. The textContent does not convert html <br> elements into newlines. Let's change the code fence markdown rendering function to use newlines instead of <br> elements hence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Bug fix
Fixes #1277
What changes did you make? (Give an overview)
Change
<br>to\nin the code fence rendererTesting instructions:
Proposed commit message: (wrap lines at 72 characters)
Change code fence html line break to newlines
The codeBlockCopyButtons plugin relies on the textContent of the code
fence html element.
The textContent does not convert html
elements into newlines.
Let's change the code fence markdown rendering function to use newlines
instead of
elements hence.