-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust margins and padding for better readability #1686
Conversation
@@ -118,6 +118,10 @@ mark { | |||
|
|||
/* Bootstrap small(sm) responsive breakpoint */ | |||
@media (max-width: 767.98px) { | |||
.indented { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's replicate this in all the other ones containing the .indented
class too for consistency (especially the docs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing that out!
I think I forgot to modify them as well when I was updating the test files 😅
.box-body-wrapper { | ||
padding: 0.75rem; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use some for the header as well to align things
.box-header-wrapper { | |
padding: 0.75rem 0.75rem 0.1rem; | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
What is the purpose of this pull request?
Resolves parts of #1669
Overview of changes:
A few adjustments to margins and padding of different elements and classes in CSS for better readability.
Anything you'd like to highlight / discuss:
.indented
,.box-body-wrapper
, and.contents
padding) target mobile devices; hence why they are inside media queries.Testing instructions:
n/a
Proposed commit message: (wrap lines at 72 characters)
Checklist: ☑️