Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust margins and padding for better readability #1686

Merged
merged 10 commits into from
Nov 4, 2021

Conversation

riyadh-h
Copy link
Contributor

@riyadh-h riyadh-h commented Nov 2, 2021

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • Others, please explain: CSS styling adjustments.

Resolves parts of #1669

Overview of changes:
A few adjustments to margins and padding of different elements and classes in CSS for better readability.

Anything you'd like to highlight / discuss:

  • Some adjustments (shrinking of .indented, .box-body-wrapper, and .contents padding) target mobile devices; hence why they are inside media queries.
  • Screenshots that show the results of these adjustments are available in this comment and this one (the first set of screenshots only).

Testing instructions:
n/a

Proposed commit message: (wrap lines at 72 characters)

Adjust margins and padding for better readability

Some elements have too big or too small margins and/or padding.

This negatively affects the readability of the contents, especially on
mobile devices.

Let's adjust these margins and padding by shrinking large ones and
increasing those that are small.

Increasing small margins/padding would separate different bodies of
text more clearly (and thus allowing the reader to easily differentiate
between them), while decreasing large margins/padding would allow for
more text to be displayed on mobile screens in particular, which
minimizes the amount of scrolling the reader needs to do.

Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

@riyadh-h riyadh-h changed the title (WIP) Adjust margins and padding for better readability Adjust margins and padding for better readability Nov 3, 2021
@riyadh-h riyadh-h marked this pull request as ready for review November 3, 2021 02:50
@@ -118,6 +118,10 @@ mark {

/* Bootstrap small(sm) responsive breakpoint */
@media (max-width: 767.98px) {
.indented {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's replicate this in all the other ones containing the .indented class too for consistency (especially the docs)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out!
I think I forgot to modify them as well when I was updating the test files 😅

.box-body-wrapper {
padding: 0.75rem;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use some for the header as well to align things

Suggested change
.box-header-wrapper {
padding: 0.75rem 0.75rem 0.1rem;
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do 👍

Copy link
Contributor

@ang-zeyu ang-zeyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@ang-zeyu ang-zeyu added this to the 3.0.7 milestone Nov 4, 2021
@ang-zeyu ang-zeyu merged commit dc5e612 into MarkBind:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants