-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix backslash bugs in convert feature #1742
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw that in one of the commits you updated the package-lock.json. Is there a reason for that?
Otherwise, LGTM 👍
I thought my package-lock.json was failing the Appveyor build. But then realized it was another issue altogether. Also, I think zeyu asked me to remove some lines from the PR #1727. |
Thanks for clarifying @ong6 :) |
#1727 (comment) Sorry for the ambiguous wording. To clarify, I meant removing the diffs. (same rationale as #1679 (comment)) fyi, the issue with appveyor: |
I've reverted the package-lock changes from #1728, which seems to be causing the changes here. |
What is the purpose of this pull request?
Fixes #1736
Overview of changes:
Updated the relativePagePath to ensure that no unnecessary
\
were being made. Done by updating a function from fsUtilAnything you'd like to highlight / discuss:
Testing instructions:
Run
markbind init -convert
on a test repo and make sure there are no instances of\
or%5C
in thelayouts/default.md
file.Build and see that there also should not have any instance of
\
or%5C
Proposed commit message: (wrap lines at 72 characters)
Resolved bug regarding backslashes in convert feature
Checklist: ☑️