Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set concurrency property to cancel unnecessary workflow runs #1821

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

tlylt
Copy link
Contributor

@tlylt tlylt commented Mar 11, 2022

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • Others, please explain:
    DevOps

Overview of changes:
Fixes #1816

  • Cancel in-progress workflow runs when multiple commits are synchronized to a PR
  • GitHub docs

Anything you'd like to highlight / discuss:
The update is such that if multiple commits are synchronized on an open PR, the queued & in-progress workflow runs will be canceled (in favor of the workflow run for the latest commit). However, push events should not be affected by this due to the concurrency group setting. This is just to be extra safe such that all push to master triggers and run the workflow to completion.

The side-effect of this is that an email will be sent out to inform that a workflow is canceled.
Testing instructions:
Tested on a test repo:

Proposed commit message: (wrap lines at 72 characters)
Cancel workflow runs when multiple commits are synchronized to a PR


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Copy link
Contributor

@jonahtanjz jonahtanjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tlylt!

LGTM 👍

@jonahtanjz jonahtanjz added this to the 4.0 milestone Mar 13, 2022
@jonahtanjz jonahtanjz merged commit 0f789ba into MarkBind:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancel in-progress workflow runs when multiple commits are synchronized to a PR
2 participants