Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MarkBind internal package dependencies #1848

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

tlylt
Copy link
Contributor

@tlylt tlylt commented Mar 22, 2022

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • Others, please explain:

Overview of changes:
Fixes #1845

Anything you'd like to highlight / discuss:
Not sure if packages/core-web/package.json's dev dep on vue-components needs to be adjusted as well (may not be necessary).

Testing instructions:
nil

Proposed commit message: (wrap lines at 72 characters)
Ensure the referenced versions of MarkBind packages are exact

The use of range versions for internal packages results in
incorrect versioning of MarkBind packages when using an
older version of MarkBind.

Let's remove the compatible versioning and use the exact match.

This ensures the versions of internal packages downloaded
will be exact and provide the expected functionalities.

Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Copy link
Contributor

@jonahtanjz jonahtanjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tlylt!

Not sure if packages/core-web/package.json's dev dep on vue-components needs to be adjusted as well (may not be necessary).

Don't think it's necessary but for consistency I think we should remove it as well.

Will also need to update the developer guide for doing a release. Usually these versions are incremented using the command lerna version --no-push (see step 2), which automatically adds in the ^. Will have to include the --exact option so that future releases will exclude the ^ as well.

@tlylt
Copy link
Contributor Author

tlylt commented Mar 22, 2022

Will also need to update the developer guide for doing a release. Usually these versions are incremented using the command lerna version --no-push (see step 2), which automatically adds in the ^. Will have to include the --exact option so that future releases will exclude the ^ as well.

Updated accordingly here.

Copy link
Contributor

@jonahtanjz jonahtanjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jonahtanjz jonahtanjz added this to the 4.0 milestone Mar 22, 2022
@jonahtanjz jonahtanjz merged commit abcf656 into MarkBind:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure referenced MarkBind packages are exact
2 participants