Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
In preparation on adding
eslint-config-airbnb-typescript
(the Typescript variant of the Airbnb style guide) for #1421, bumped some dependencies regarding to ESLint and other related dependencies.Overview of changes:
Bumped
eslint
,eslint-plugin-import
, andeslint-config-airbnb-base
to the latest version.eslint
, it is bumped to the highestv7
version (thoughv8
is already available).eslint-config-airbnb-base
, the version after the current one jumps to15.0.0
Anything you'd like to highlight / discuss:
The
eslint-config-airbnb-base
bump reports new lint errors to our current codebase, particularly due to some rules that were not enabled before and are enabled now:prefer-regex-literals
(~11 new errors)default-param-last
(~2 new errors)function-call-argument-newline
(most new errors are from this rule, ~29)I turned all of them off now, but we can discuss below whether we can enable some of the rules and fix some of the violations in this PR, in a separate PR, or keep them disabled.
My opinions:
prefer-regex-literals
: Should enable, fix the violations.default-param-last
: Might enable it, but fixing the violation is a little work (the offender is the Site constructor). Can leave it off too.function-call-argument-newline
: Keep it turned off. There's too much cases of both newline and non-newline function calls in our code. Enabling it for one option makes the other case look worse stylistically.Testing instructions:
Check
npm run lint
, should be okay.Proposed commit message: (wrap lines at 72 characters)
Bump ESLint dependencies
Checklist: ☑️