Remove padding top from navbar site logo

[elroygohjy]

What is the purpose of this pull request?

• Documentation update
• Bug fix
• Feature addition or enhancement
• Code maintenance
• Others, please explain:

Overview of changes:
Resolves #1895

Anything you'd like to highlight / discuss:
Remove padding top from .nav-left class selector.

Before:

After:

Testing instructions:
Inspect navbar site logo and it is now align-center with other navbar elements.

Proposed commit message: (wrap lines at 72 characters)
Remove padding top from site logo

[damithc]

Thanks for the PR @elroygohjy Indeed the 'after' one looks better.
🤔 hmmm... are we sure we want to change a general navbar style like this? It will affect every MarkBind site. Could the problem lie with the specific logo image rather than the style?

[elroygohjy]

Hello prof,
This problem is definitely not caused by the logo used.
So, current logo height is 20px as shown:

But, there is addition 10px of padding-top that is hidden, although the height of navbar-brand should be 30px inclusive of padding, and it is not aligning center.

This is the reason why the logo is not aligning.
My current implementation failed to understand this problem, i will be creating a new commit that removes this 10px of padding and to center the logo.

[jonahtanjz]

Thanks for investigating and fixing this @elroygohjy. Nice work :)

Just one question, the rest looks good :)

[jonahtanjz]

Suggested change

	svg {
	.navbar-brand > svg {

Should this have the .navbar-brand selector as well? If not this will select all svg elements.

[jonahtanjz]

LGTM 👍