-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug to allow highlighting of code with '-' #2132
Merged
jovyntls
merged 6 commits into
MarkBind:master
from
yucheng11122017:fixBugWhereCannotHighlightDash
Feb 5, 2023
Merged
Fix bug to allow highlighting of code with '-' #2132
jovyntls
merged 6 commits into
MarkBind:master
from
yucheng11122017:fixBugWhereCannotHighlightDash
Feb 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fixBugWhereCannotHighlightDash
ong6
approved these changes
Feb 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jovyntls
approved these changes
Feb 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working on my end! LGTM
jovyntls
changed the title
Fix bug where cannot highlight dash
Fix bug to allow highlighting of code with '-'
Feb 5, 2023
@all-contributors please add @yucheng11122017 for code |
I've put up a pull request to add @yucheng11122017! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR is a follow-up to #2125 to rectify the accidental merge.
What is the purpose of this pull request?
Overview of changes:
Trying to highlight code which contained a '-' did not work since the highlight rules were parsed according to '-'.
Eg. {highlight-lines="1['block-level']"}
Change to parse using regex in which '-' cannot be within a
[]
.Anything you'd like to highlight/discuss:
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Fix bug to allow highlighting of code with '-'
Checklist: ☑️