Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TypeScript Migration documentation on git hooks #2151

Merged
merged 3 commits into from
Feb 11, 2023

Conversation

lhw-1
Copy link
Contributor

@lhw-1 lhw-1 commented Feb 9, 2023

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Overview of changes:

Resolves #2144.

Minor documentation update to let developers know that git hooks may interfere with "Rename" commits due to them building the backend (all three git hooks).

Anything you'd like to highlight/discuss:

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)
Update TypeScript Migration documentation on git hooks


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

@lhw-1 lhw-1 requested a review from raysonkoh February 9, 2023 08:40
Copy link
Contributor

@tlylt tlylt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lhw-1 for noting this, possibly saving precious developer time 👍 Some nits commented.

docs/devGuide/development/migratingToTypeScript.md Outdated Show resolved Hide resolved
docs/devGuide/development/migratingToTypeScript.md Outdated Show resolved Hide resolved
Copy link
Contributor

@raysonkoh raysonkoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tlylt tlylt added this to the 4.0.3 milestone Feb 11, 2023
@tlylt tlylt merged commit 7ca56e4 into MarkBind:master Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflicts with git hooks and rename commits of TypeScript migration
3 participants