Eslint: Lint .eslintrc.js #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acjh
commented
May 31, 2018
| "**/gulpfile.*.js", // gulp config | ||
| "**/Gruntfile{,.js}", // grunt config | ||
| "**/protractor.conf.js", // protractor config | ||
| "**/protractor.conf.*.js", // protractor config |
There was a problem hiding this comment.
@nicholaschuayunzhi Did you get these from somewhere, or can I sort alphabetically?
There was a problem hiding this comment.
I got it off the airbnb config last time.
https://github.com/airbnb/javascript/blob/ae82d7678303bd08242299a4a9e2c47717bf9c6b/packages/eslint-config-airbnb-base/rules/imports.js#L71-L91
It was to allow mock folders to import dev dependencies. At the time of the commit, they had only just committed the change and was not released yet.
There was a problem hiding this comment.
Looks like it's still not released yet. I'll keep the order then. Thanks!
yamgent
approved these changes
Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Other, please explain: Code quality
What is the rationale for this request?
Consistency. These are used in .eslintrc.js because the official guide uses double quotes:
What changes did you make? (Give an overview)
!.eslintrc.jsto .eslintignoreProvide some example code that this change will affect:
Is there anything you'd like reviewers to focus on?
-
Testing instructions:
$ npm run lint