-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for expressive layouts with page.md #944
Conversation
No comments so far for the current features that the prototype has, looking forward to the final implementation. 👍 Btw, if there are a lot of refactoring to be done, and those refactoring might also benefit other features (not necessary just for expressive layout), you might want to consider handling the refactoring in separate PRs, so that this PR doesn't get too big. |
5eb6689
to
0f86938
Compare
Keeping things super simple for now to ensure that this PR does not go out of hand:
Important functional and non-functional requirements that this PR takes care of:
Many more work to be done but will be separated to different PRs. A non-exhaustive list include:
|
47d3995
to
6d27b45
Compare
test/functional/test_site_convert/expected/contents/topic1.html
Outdated
Show resolved
Hide resolved
a1d3816
to
ff860e6
Compare
test/functional/test_site_templates/test_default/expected/index.html
Outdated
Show resolved
Hide resolved
Just to let you know that I will take a look at this soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate your patience. I left some comments, but I feel that the comment with the '⭐⭐' as the first line is probably the most important thing that you might want to address first.
test/functional/test_site_expressive_layout/_markbind/layouts/default/page.md
Outdated
Show resolved
Hide resolved
83ffcbc
to
d9252c9
Compare
…into user defined expressive layouts template
09c4350
to
61d4bfc
Compare
Ready for review |
test/functional/test_site_expressive_layout/_markbind/layouts/default/page.md
Show resolved
Hide resolved
61d4bfc
to
4db44e0
Compare
4db44e0
to
b070f32
Compare
b070f32
to
ea770e8
Compare
{{ mainContentBody }} | ||
</box> | ||
|
||
which injects the actual page content in every page. This allows you to build layouts in different ways. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reads better this way?
The
page.md
file of a layout should come with the reserved variable{{ MAIN_CONTENT_BODY }}
which injects the actual page content in every page. This allows you to build layouts in different ways.
Alternatively, can be written this way (i.e., avoid breaking sentences across boxes):
The
page.md
file of a layout should come with the following reserved variable which injects the actual page content in every page.{{ MAIN_CONTENT_BODY }}
This allows you to build layouts in different ways.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] New feature
Resolves #631
Currently this is a WIP but the Proof of Concept generally working. The idea is for user to define a main page structure to allow users to define wrapper content around their main content.
For instance:
Code:
![image](https://user-images.githubusercontent.com/4986717/69496205-91e4c500-0f0a-11ea-81f3-ea80e6705a43.png)
Result:
![image](https://user-images.githubusercontent.com/4986717/69496182-64981700-0f0a-11ea-844c-db4eec2119a9.png)
Definitely a lot more work to be done: