Avoid add_compile_options in the toolchain file #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompiler options in the toolchain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#70 correctly called out that
add_compile_optionsas used in the toolchain wasn't right - as per the documentation "These options are used when compiling targets from the current directory and below" - which means that all targets get the options, even if the target isn't C++. The more correct option is to useCMAKE_LANG_FLAGS_INIT, which allows the toolchain to set the compilation flags for a specific language - in this caseCXX.To help validate, I've added an 'example' project that compiles as C, which should help make sure that C++ options aren't incorrectly picked-up by the C compiler.