Issue 575: Migration to rails 3.1 #1180
Conversation
Done : - edited Gemfile - moved from public/ to assets/ - added `config.assets.enable = true` in config/application.rb - commented lines about rjs in config/environments/development.rb - added lines about uglifier and scss - added app/assets/stylesheets/application.css - added app/assets/application.js TODO: - move application.js in javascripts - resolve images not found - remove files not needed like rails.js, jquery.js...
- moved application.js inside assets/javascripts - removed jquery.js, prototype.js and rails.js to use the gems.
in - annotation_categories_controller_test.rb - assignments_controller_test.rb
added some fixtures files
for: - results_controller_test - rubrics_controller_test
|
@benjaminvialle The reason we experienced so many errors was because we require a newer mysql2 gem. After the latest commit, I see:
Much more manageable number to fix :) |
|
@danielstjules nice catch for mysql2 gem ;) On my side, with postgresql, I've got: |
|
Yeah, I'll be working through this today. Will hopefully get them all fixed for postgres and mysql. Do we still support sqlite? |
|
At the moment, we don't support sqlite as Markus is doing concurrent acces to the DB and sqlite don't support them. But I think concurrent access are not required in MarkUs. We should remove them and then test again with sqlite. |
|
A good chunk of the errors seem to be from the following change in Rails 3.1:
Easy enough. I'll see what I can get through this week. |
…entry_forms_controller_test.rb
|
Finally getting around to working on this again. With mysql, all unit tests pass, but still have 3 failures among functional tests. I'll fix those tomorrow. Then next up will be fixing the assets, and the issue with sessions. |
|
Hi @danielstjules it's good to see your working on this PR. Do you still have sessions issues? Because @ghigt and I corrected this on master before releasing 1.0-alpha. |
|
Yes, still having issues - I'm looking into it this afternoon. The branch is up-to-date with those changes GhiGt pushed. Unfortunately, there's more to it than just the inclusion of |
assets/javascripts, re-enabled no-conflict
…to int. This fixed the failing tests in submission_controller
|
@benjaminvialle Would you mind running the tests with your setup? |
… image urls in main.css.scss
|
With ruby-1.9.3-p194 (the error in functional tests is a old one) :
1026 tests, 3227 assertions, 1 failures, 0 errors, 0 skips With ruby-1.8.7-p358 (the error in functional tests is a old one) :
1026 tests, 3207 assertions, 1 failures, 0 errors Good work! \o/ |
|
@benjaminvialle That's the same issue you reported when the updated api/users was first merged: #1014 Do you think you could make an issue for this and outline some different aspects of your environment? As for this pull request, it should be ready to merge very shortly! |
|
@benjaminvialle I think it's ready :) |
|
Will test your PR as soon as possible :) |
|
@danielstjules I'm merging this PR. I tested it and I didn't find any bugs related to the migration to Rails 3.1. We need to update the documentation as Rails 3.1 requires a javascript vm to run. (ruby-execjs package on Debian GNU/Linux systems) |
Closes #575: Migration to rails 3.1
A continuation of #1153
In reference to #575
Will be working on it this weekend.