Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coveralls and simplecov CI configuration #6592

Merged
merged 1 commit into from
May 22, 2023

Conversation

david-yz-liu
Copy link
Contributor

@david-yz-liu david-yz-liu commented May 22, 2023

Motivation and Context

Currently the Coveralls report is incomplete (reporting ~45% rather than ~85-90%) and only runs on pull requests. I reviewed and updated the current configuration.

Your Changes

Description:

  • Configured RSpec and SimpleCov to merge the rspec and rspec spec/system coverage reports.
  • Updated Coveralls GitHub Action to v2
  • Updated action to run on pushes to master (this will ensure a consistent coverage report)
  • (not in diff) Modified Coveralls configuration to leave comments on pull requests.

Type of change (select all that apply):

  • Other (please specify): CI update

Testing

Ensured Coveralls Action ran correctly on this pull request.

Questions and Comments (if applicable)

Checklist

  • I have performed a self-review of my own code.
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported on Coveralls.

@david-yz-liu david-yz-liu merged commit 91143b5 into MarkUsProject:master May 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants