Fix remaining test failures #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code switched meanwhile to use :x1, :x2, :y1, :y2 over :coords as parameters.
Use File.expand_path() everywhere so as to be able to run one test file with: $ ruby path/to/test_file.rb
A couple of test errors were thrown and an exception showed up when the "Grades" tab was selected for a marks spreadsheet. As it turnes out, the problem was that the lambda took no arguments but was called with two arguments. See app/controllers/grade_entry_forms_controller.rb line 29. This fix only changes the offending lambda to take two dummy arguments. That is needed as the pagination helper routine is also called by the submissions table controllers.
benjaminvialle
added a commit
that referenced
this pull request
Jun 29, 2012
Fix remaining test failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these commits the tests all pass for me using Ruby 1.9.3 and SVN 1.6.17. Haven't run the suite with 1.8.7 yet. So far so good.
I've also fixed some missing File.expand_path() calls.