Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue 315: config locale fall back to english in production environment. #854

Merged
merged 1 commit into from Oct 1, 2012
Merged

issue 315: config locale fall back to english in production environment. #854

merged 1 commit into from Oct 1, 2012

Conversation

antez
Copy link
Contributor

@antez antez commented Sep 29, 2012

This is my solution to issue #315.

Testing
Manual:

  1. Comment out an entry in /config/locales/fr.yml, "welcome_to:" for example.
  2. Run Markus in dev mode, go to http://0.0.0.0:3000/fr and note that fall back doesn't happen on the login page("translation missing").
  3. Run Markus in production mode(rails s -e production) and go to http://0.0.0.0:3000/fr
  4. Fall back to english("Welcome to MarkUs!")

jerboaa added a commit that referenced this pull request Oct 1, 2012
@jerboaa
Merge pull request #854 from antez/issue315
2d3c12d 
issue 315: config locale fall back to english in production environment.
@jerboaa jerboaa merged commit 2d3c12d into MarkUsProject:master Oct 1, 2012
@jerboaa jerboaa mentioned this pull request Oct 1, 2012
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antez @jerboaa