Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert jdk-12 to jdk-8 #198

Merged

Conversation

mishaschwartz
Copy link
Contributor

@mishaschwartz mishaschwartz commented Jun 3, 2019

  • if you want to use jdk-12 you can update manually after the java/jdbc install or you can change the install script for the java/jdbc testers before running yourself
  • Eventually when installing jdk-12 by default makes more sense/is easier to do we can do that (see update jdk version from jdk-8 #197)

@mishaschwartz mishaschwartz changed the title Revert jdk-12 to jdk-8 Revert jdk-12 to jdk-11 Jun 5, 2019
@david-yz-liu
Copy link
Contributor

@mishaschwartz If only available on 18.04+ then please leave this at version 8 for now. I plan to merge this in soon (so that it fixes my build).

@mishaschwartz
Copy link
Contributor Author

@david-yz-liu I'm just about to update the PR on the Markus side to update the vagrant machine to 18.04 as we discussed.

@mishaschwartz mishaschwartz changed the title Revert jdk-12 to jdk-11 Revert jdk-12 to jdk-8 Jun 5, 2019
@david-yz-liu
Copy link
Contributor

@mishaschwartz I realized, we should probably wait to upgrade to JDK 11/12 anyway until the teaching labs do.

@mishaschwartz
Copy link
Contributor Author

@david-yz-liu it is currently being discussed since we are upgrading everything to 18.04 this semester. It would be good to have a jdk-11 in development at least so we can catch any issues before we have to use jdk-11 in production.

@david-yz-liu david-yz-liu merged commit 438635c into MarkUsProject:master Jun 5, 2019
@mishaschwartz mishaschwartz deleted the java-version-revert branch June 5, 2019 15:53
david-yz-liu added a commit that referenced this pull request Jun 5, 2019
david-yz-liu added a commit that referenced this pull request Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants