Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add list support #50

Merged
merged 7 commits into from
Jul 3, 2020
Merged

Add list support #50

merged 7 commits into from
Jul 3, 2020

Conversation

xylix
Copy link
Collaborator

@xylix xylix commented Jun 23, 2020 •
edited
Loading

  • Fix getting list selections
  • fix selecting from dropdown list (problem is reproduced in test Select From List)

@xylix xylix mentioned this pull request Jun 23, 2020
Closed
12 tasks
@xylix
Start adding list support and tests
e066620
@xylix
Use page should contain element to validate select existense in test.…
cd088a0 
… Implement PW behaviour for getting select contents

Fully working list selection validation

Add select in select element keyword, improve list selection should be

Update select-lists test
@xylix xylix force-pushed the master branch 4 times, most recently from 8efb419 to e023ee8 Compare June 25, 2020 09:51
@xylix
Copy link
Collaborator Author

xylix commented Jun 26, 2020

Current problem with getting this working seems to be mostly related to how we parse / pass / playwright treats our `{label: "Email"} matcher.

However this playwright pen https://try.playwright.tech/?s=z3h6c works, so it can't be only on PW side. I also tried coding the selector and matcher in .ts side to ensure it's not a problem with variable passing or something weird like that.

It could also be related to my select content fetching method https://github.com/MarketSquare/robotframework-browser/pull/50/files#diff-8de88b7bcd474a2cd0ffd131cb81e50dR173 but after adding Small select from list test this seems unlikely since it doesn't do any list entry validation, only tries to mutate the dropdown once.

Docs:
PW api doc and source code
https://github.com/microsoft/playwright/blob/master/docs/api.md#pageselectoptionselector-values-options
https://github.com/microsoft/playwright/blob/1865c5685a34a2e91ace07e08aee7ef15261406c/src/dom.ts#L408

@xylix xylix added this to In progress in Next release Jun 26, 2020
@xylix xylix force-pushed the master branch 3 times, most recently from 5419cd5 to 94cea16 Compare June 26, 2020 09:00
@xylix xylix moved this from In progress to To do in Next release Jun 29, 2020
@xylix xylix assigned xylix and unassigned xylix Jul 1, 2020
@xylix xylix added the enhancement New feature or request label Jul 1, 2020
@xylix xylix moved this from To do to In progress in Next release Jul 3, 2020
@xylix xylix changed the title WIP: Add list support Add list support Jul 3, 2020
@xylix xylix moved this from In progress to Blocked / Under review in Next release Jul 3, 2020
@xylix xylix merged commit fed593d into master Jul 3, 2020
Next release automation moved this from Blocked / Under review to Done Jul 3, 2020
@xylix xylix deleted the add-list-support branch July 3, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
Next release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@xylix