exit 1 on No source path provided

[DetachHead]

closes #208

[codecov-commenter]

Codecov Report

Merging #210 (96183e5) into main (87313d7) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   96.17%   96.01%   -0.16%     
==========================================
  Files          29       29              
  Lines        1699     1708       +9     
==========================================
+ Hits         1634     1640       +6     
- Misses         65       68       +3     

Impacted Files	Coverage Δ
robotidy/cli.py	93.00% <100.00%> (ø)
robotidy/transformers/OrderSettings.py	98.18% <0.00%> (-1.82%)	⬇️
robotidy/transformers/MergeAndOrderSections.py	98.41% <0.00%> (-1.59%)	⬇️
robotidy/transformers/ReplaceRunKeywordIf.py	97.29% <0.00%> (-1.36%)	⬇️
robotidy/transformers/NormalizeAssignments.py	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87313d7...96183e5. Read the comment docs.

[bhirsz]

Thanks for the PR! Tests are failing because there are some CLI e2e tests where I test some CLI option and do not set source path. the solution is either set the path or set expected exit_status to 1.

robotframework-tidy/tests/utest/test_cli.py

Line 414 in 87313d7

result = run_tidy()

add exit_code=1

This test look invalid (it doesn't really test anything, just "tidy did not trip over during run"). So you could remove it - and I can try to add better tests for iterating paths recursively later:

robotframework-tidy/tests/utest/test_cli.py

Line 31 in 87313d7

run_tidy(src)

[DetachHead]

Thanks, will fix when I get home

[DetachHead]

@bhirsz should be all good now