Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AppConfig so we support Django 1.9+ #11

Closed
wants to merge 1 commit into from
Closed

Use AppConfig so we support Django 1.9+ #11

wants to merge 1 commit into from

Conversation

blag
Copy link
Collaborator

@blag blag commented Jun 1, 2016

No description provided.

@blag
Copy link
Collaborator Author

blag commented Jun 1, 2016

This should help my other PRs (#8, #9, and #10) pass the Travis tests.

@blag blag mentioned this pull request Jun 1, 2016
Closed
@blag blag closed this Jun 1, 2016
@blag
Copy link
Collaborator Author

blag commented Jun 1, 2016

Closing and reopening PR so Travis runs again.

@blag blag reopened this Jun 1, 2016
@blag
Copy link
Collaborator Author

blag commented Jun 1, 2016 •
edited
Loading

Whelp, I don't know why only Python 3.3/Django 1.9 and Python 3.3/Django master are failing, but the rest of them are passing.

Figured it out: Django 1.8+ no longer supports Python 3.0 through 3.3 (2.7 is still supported).

Anyway, sorry for all of the noise. Once this is merged I'll rerun the Travis tests for my other PRs. Thanks for all of your work!

@blag blag force-pushed the django-1.9-support branch 3 times, most recently from f3b0bf7 to 3247b19 Compare June 1, 2016 04:45
@MarkusH
Copy link
Owner

MarkusH commented Jun 2, 2016

Thanks for the patch. Could you update the test matrix (travis and tox) to follow https://github.com/MarkusH/django-dynamic-forms 😸

Also, mind squashing the commits into a single one.

@blag
Copy link
Collaborator Author

blag commented Jun 2, 2016

Done.

@blag blag mentioned this pull request Jun 3, 2016
Merged
@MarkusH
Copy link
Owner

MarkusH commented Jun 3, 2016

Thanks for your work. Merged in 29ea078 🍪 🍎

@MarkusH MarkusH closed this Jun 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blag @MarkusH