Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access PID Autotune from LCD #3135

Closed
Spoonunit opened this issue Mar 12, 2016 · 8 comments
Closed

Access PID Autotune from LCD #3135

Spoonunit opened this issue Mar 12, 2016 · 8 comments
Labels
T: Feature Request Features requested by users.

Comments

@Spoonunit
Copy link

It would be great if there was an option, perhaps from the "Prepare" menu, to run PID Autotune and read off the results from that on screen. While not absolutely vital to success, having PID tuned for your printer and environment leads to much tighter control of the hot end temperature and more successful first time prints. Once you have these numbers, you can choose to push them into your own firmware build or run them as part of your GCODE starting script. This would be nice to do as part of the commissioning process of a printer, prior to actually hooking up other tools that give you access to a GCODE terminal.

@Blue-Marlin
Copy link
Contributor

Step a) would be to extend M303 with a parameter to actually use the new values instead only displaying them. That's not too complicated.
Step b) would be a, because of the at least 2 needed parameters, relative complicated/big menu.
Storing in the EEPROM is already there.

An extra cool feature could be temperature dependent PID tables, using different parameters for different target temperatures

@Spoonunit
Copy link
Author

Also nice would be for PID values to be loaded for the tool in operation instead of using a single set of PID values for all tools. These values could be loaded during tool change, something which you can actually do using most slicers already, but might be nice to have the firmware handle it. Also, if the inactive tool drops out of range while different PID values are in operation for the active tool, that probably shouldn't trigger a halt situation (not sure if that happens right now, I'm a little new to this)

@WPBack
Copy link
Contributor

WPBack commented Mar 20, 2016

I am thinking about trying to implement this, but I wonder what extra parameter you think I should use in step A above. U maybe for Use? And also, should it save it to EEPROM or only use it temporarily?

@duncanford
Copy link

I would say temporary; it can always be stored with Store Memory. U seems like a sensible choice; intuitive. As long as this isn't used for other, conflicting meanings. Another idea would be perhaps to make it M3031? Elsewhere it seems like alternate numbers are used to distinguish between do and save.

@WPBack
Copy link
Contributor

WPBack commented Mar 20, 2016

Temporary is probably right. Another code would probably be the best potion, but can you really have codes higher than 999? I'm not sure since I'm pretty new to this.

WPBack added a commit to WPBack/Marlin that referenced this issue Mar 20, 2016
Adds the parameter U to M303. If U1 is included , it will use the
PID-values from the auto-tune.
@AnHardt
Copy link
Member

AnHardt commented Mar 20, 2016

codenum is currently a int (16bit signed), but could be enlarged.
But new g-codes are much more problematic than added parameters.

WPBack added a commit to WPBack/Marlin that referenced this issue Mar 20, 2016
Added a menu-element under the Temperature-menu to auto-tune the
PID-regulators for the temperatures
@thinkyhead thinkyhead added the T: Feature Request Features requested by users. label Mar 27, 2016
@thinkyhead
Copy link
Member

This feature has been merged into RCBugFix. Just enable the PID_AUTOTUNE_MENU option. It works, but needs a small tweak – basically an option to cancel or proceed, since it's a long procedure involving heating. For now, to "cancel" just wait for the LCD to time-out back to the Info Screen.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: Feature Request Features requested by users.
Projects
None yet
Development

No branches or pull requests

6 participants