Allow py scripts to handle spaces in paths #14876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The extra ' in the encrypter part seems to prevent it from outputting the Robin.bin. Changing: |
|
the whole commit may need a revert if its the case... indeed as i use the stflash directly, i commented alfawise one locally (the .py script) |
tpruvot
added a commit
to tpruvot/Marlin
that referenced
this pull request
Aug 11, 2019
)" This reverts commit f9f20bb.
|
ok, made the PR #14926 for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where spaces in paths would break some build scripts. Solution from @jmz52 at #14697.