-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce size of menu code #1620
Reduce size of menu code #1620
Conversation
thinkyhead
commented
Mar 16, 2015
- Get rid of _selected functions, passing selected state instead
- Reduces code size by 6 - 7K !
- Get rid of _selected functions, passing selected state instead
- Compare pr_char to space - Fewer calls to lcd_strlen
@thinkyhead |
@AnHardt Good idea! I guess I stuck to that because it was the convention, so it will be good to get past that and make the code more properly expressive. |
this one seems logic to merge... but is it to early? |
Get upstream changes
- Pass selected state directly to lcd_implementation_mark_as_selected - Rename sel function parameter - Include a minor fix for SdBaseFile.h
With this last commit it should be ready. Waiting for Travis to pass it. |
In the new method we pass the character that should be used for selected state, not the character to print always.
@thinkyhead May be the same as: |
@thinkyhead |
@thinkyhead No, not newly-scrolled items. |
@thinkyhead |
@AnHardt I see, so the menu was failing to scroll. Well, I'm excited you found the issue. Checking out the code now.... |