Update test scripts to error on unknown #16229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the Free Memory test fixes are exposing a bug. I can disable these tests, or maybe someone who knows about the M100 Free Memory stuff can fix the bug. Build failure: https://travis-ci.org/jeffeb3/Marlin/jobs/625311692 |
|
ACTION_KILL is also failing. I'll disable it to replicate the previous behavior, but if we want that tested, someone will have to fix it. Build failure: https://travis-ci.org/MarlinFirmware/Marlin/jobs/625317268 |
Changing these sed commands to return non-zero, and exit early if a particular parameter isn't exactly matched. This should make the tests more robust to changes in parameter names.
thinkyhead
force-pushed
the
tests/sed_with_exit_value
branch
from
5f001c1
to
1957a1e
Compare
thinkyhead
changed the title
philippniethammer
pushed a commit
to philippniethammer/Marlin
that referenced
this pull request
Dec 21, 2019
christran206
pushed a commit
to christran206/Marlin2.0-SKR-Mini-E3-1.2
that referenced
this pull request
Dec 30, 2019
webs1821
added a commit
to webs1821/Marlin
that referenced
this pull request
Jan 2, 2020
* [cron] Bump distribution date * STM32F1 Flash-based EEPROM fixes (MarlinFirmware#16118) * Disable PRINTCOUNTER in SKR Mini E3 examples (MarlinFirmware#16110) * Fix compile error with disabled PIDTEMP (MarlinFirmware#16108) * Wanhao D6 uses TINYBOY2 (MarlinFirmware#16117) * Improve touch buttons behavior (MarlinFirmware#16109) * Update AZSMZ LCD link (MarlinFirmware#16106) * [cron] Bump distribution date * Update 3DFabXYZ settings (MarlinFirmware#16139) * [cron] Bump distribution date * Fix controller and SD on Robin Nano (MarlinFirmware#16187) * Correct MKS Robin Mini pins (MarlinFirmware#16178) * Formalize DAC percent strings (MarlinFirmware#16176) * Update Italian language (MarlinFirmware#16147) * Update french (objects, retract...) * Superscript 3 for mm3 * [cron] Bump distribution date * Add MKS Robin Pro, MKS Robin Lite3 (MarlinFirmware#16163) * Fix multiple servos with STM32 (MarlinFirmware#16151) * Use error message !! hints (MarlinFirmware#16145) * Update BTT comments for USB/SD Composite (MarlinFirmware#16130) * MKS 12864 OLED pins for SGEN-L (MarlinFirmware#16188) * Invert E dir of Geeetech A10 (MarlinFirmware#16149) * Disable SD_CHECK_AND_RETRY in BTT E3 configs (MarlinFirmware#16143) * Add a CI test for RAMBo + CNC (MarlinFirmware#16126) * Onboard (always-on) pullups support (MarlinFirmware#16144) * Tweak ExtUI Probeless Babystepping (MarlinFirmware#16177) * Fix RAMBo CNC test * Flsun QQ-S example config (MarlinFirmware#16204) * Add MKS Robin Mini EEPROM defines (MarlinFirmware#16203) * Fix compile error (macro substitution typo) (MarlinFirmware#16194) * Update M503 MBL G29 report (MarlinFirmware#16199) * Include Z in SCARA steps feedrate (MarlinFirmware#16193) * Cardreader read/write open methods * Tweak some config names * Improve A20M config * Move status screen defines * Fix bad #ifdef (MarlinFirmware#16227) * TOUCH_MI_DEPLOY_XPOS fallback to X_MIN_POS (MarlinFirmware#16226) * Fix MKS SGen-L SD detect pin (MarlinFirmware#16224) * Improve ESP32 HAL (EEPROM, watchdog) (MarlinFirmware#16228) * Fix G28 debug line, M569 calls (MarlinFirmware#16213) * Add SKR Mini E3 + Zonestar LCD warning (MarlinFirmware#16214) * STM32 Touch UI timings, Longer onboard pullups (MarlinFirmware#16219) * Update BTT002 platform (fixing SD init) (MarlinFirmware#16217) * Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script * Move AutoBuildMarlin to its own repo * [cron] Bump distribution date * Tweak G34, fix a declaration * Sanity-check Z_STEPPER_AUTO_ALIGN coordinates (MarlinFirmware#16231) * Improve SKR mini E3 + Ender 3 settings (MarlinFirmware#16247) * Tweak code formatting * Allow TMC2209 to save/restore spreadCycle (MarlinFirmware#16153) Co-Authored-By: teemuatlut <teemu.mantykallio@live.fi> * Spindle/Laser pins for RADDS (MarlinFirmware#16119) * Improve pulse timing and step reliability (MarlinFirmware#16128) * BigTreeTech SKR v1.4 support (MarlinFirmware#16236) * Followup to TMC2209 spreadcycle patch * Remove obsolete TMC2209 comment * HOME_USING_SPREADCYCLE is obsolete Co-Authored-By: teemuatlut <teemu.mantykallio@live.fi> * Use MYSERIAL0 (not SerialUSB) for Malyan LCD * Followup for step timing (MarlinFirmware#16128) * Fix broken M100_dump_routine * Tweak sanity checks * Update test scripts to error on unknown (MarlinFirmware#16229) * Kossel Clear configuration (MarlinFirmware#16198) * Move pins debug condition * Use Github Actions for CI, date bump (MarlinFirmware#16269) * Fix HAL_STM32 + Arduino IDE SoftwareSerial conflict (MarlinFirmware#16266) * Improve Anet A6 config (MarlinFirmware#16280) * Fix G34 with Z_DUAL_STEPPER_DRIVERS compile (MarlinFirmware#16274) * Fix planner compile error (MarlinFirmware#16272) * Fix axis CS sanity check (MarlinFirmware#16271) * Add Tevo Nereus (w/ Robin Nano) config (MarlinFirmware#16207) * Don't test certain changes * Reset runout.ran_out on resume (MarlinFirmware#16230) * Step timing cleanup and rounding fix (MarlinFirmware#16258) * Add MRR_ESPA/_ESPE (ESP32) boards (MarlinFirmware#16238) * Add Ender-5 Pro config (MarlinFirmware#16221) * Add FLYBOARD (STM32F407ZG) (MarlinFirmware#16257) * Fix STM32 flush of TX (used by UBL) (MarlinFirmware#16197) * Flash leveling (for some STM32) (MarlinFirmware#16174) * Some ESP32 patches (MarlinFirmware#16297) * MKS SGen-L pins EEBF or EFBF scheme (MarlinFirmware#16296) * Release version 2.0.0 * Add Rumba32 support for PIO (MarlinFirmware#16202) * MKS Robin 2 (STM32F407ZE) base support (MarlinFirmware#16270) * Update Czech language (MarlinFirmware#16305) * Sync SKR E3 configs (MarlinFirmware#16301) * Add NOZZLE_AS_PROBE (no probe offsets) (MarlinFirmware#15929) * Version 2.0.1 * Update build status url Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com> Co-authored-by: randellhodges <rhodges@taxfodder.com> Co-authored-by: Jason Smith <jason.inet@gmail.com> Co-authored-by: Antti Andreimann <anttix@users.sourceforge.net> Co-authored-by: thisiskeithb <13375512+thisiskeithb@users.noreply.github.com> Co-authored-by: Tanguy Pruvot <tpruvot@users.noreply.github.com> Co-authored-by: Luu Lac <45380455+shitcreek@users.noreply.github.com> Co-authored-by: Alain Martel <alain74martel@gmail.com> Co-authored-by: Anders Sahlman <57940217+AndersSahlman@users.noreply.github.com> Co-authored-by: dagorel <37673727+dagorel@users.noreply.github.com> Co-authored-by: Giuliano Zaro <3684609+GMagician@users.noreply.github.com> Co-authored-by: MS1987 <lms228@163.com> Co-authored-by: MangaValk <patrickvalkmanga@hotmail.com> Co-authored-by: André Kjellstrup <andre.kjellstrup@gmail.com> Co-authored-by: Tobias Schürg <tobiasschuerg@gmail.com> Co-authored-by: Jeff Eberl <jeffeb3@gmail.com> Co-authored-by: ManuelMcLure <manuel@mclure.org> Co-authored-by: InsanityAutomation <38436470+InsanityAutomation@users.noreply.github.com> Co-authored-by: iain MacDonnell <github@dseven.org> Co-authored-by: Bo Herrmannsen <bo.herrmannsen@gmail.com> Co-authored-by: Luc <8822552+luc-github@users.noreply.github.com> Co-authored-by: danym21 <54744475+danym21@users.noreply.github.com> Co-authored-by: chzj333 <53591189+chzj333@users.noreply.github.com> Co-authored-by: Vertabreaker <opyrus@hotmail.com> Co-authored-by: Moshi Binyamini <MoshiBin@users.noreply.github.com> Co-authored-by: salami738 <24863070+salami738@users.noreply.github.com> Co-authored-by: elementfoundry <57408038+elementfoundry@users.noreply.github.com> Co-authored-by: teemuatlut <teemu.mantykallio@live.fi> Co-authored-by: Mario Costa <mario.silva.costa@gmail.com> Co-authored-by: BigTreeTech <38851044+bigtreetech@users.noreply.github.com> Co-authored-by: Markus Towara <mtowara@gmail.com> Co-authored-by: FLYmaker <49380822+FLYmaker@users.noreply.github.com> Co-authored-by: ferengi82 <christian.maurer@gmx.eu> Co-authored-by: petrzjunior <junior@zahradnik.cz>
webs1821
pushed a commit
to webs1821/Marlin
that referenced
this pull request
Jan 2, 2020
griehsler
pushed a commit
to griehsler/Marlin
that referenced
this pull request
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These sed scripts are pretty good, but they don't fail if the configuration value isn't found.
set -eto exit on all failures.As I hoped, it found a few errors in the existing test configurations. I fixed each of them, here is a breakdown of those:
megaatmega2560:
M100_FREE_MEMORY_DUMPER
M100_FREE_MEMORY_CORRUPTOR
These aren't in the Configuration, but they do affect the build. I changed these to opt_add. I didn't have a way to verify that they actually enabled the features though.
ACTION_ON_KILL
This has a #ifndef, #define in the Configuration_adv.h. I changed it to an opt_add, but now that I'm writing this, that doesn't really make sense either.
It should probably either get removed, or be some other test.. Update. It is stopping the build. I'm removing it.BLTOUCH_FORCE_5V_MODE
As far as I can tell, this isn't a feature anymore. I deleted it.
LPC1768
SERIAL_PORT2
This has a config for RAMPS, trying to set serial port 2. RAMPS doesn't have a serial port 2, and enabling it was causing a compile error. It was passing because the name was wrong. So I removed it.
esp32
WIFI_SSID
These arguments weren't being set right, so it wasn't finding a substitution. I've verified the output is WIFI_SSID gets set to
"ssid".Default config
There was a slight mismatch between the default config and Marlin/Configuration.h in the whitespace.
restore_configswould change the file from a fresh checkout. This just fixes that whitespace.Benefits
The tests should be less fragile, and if someone changes the name of a parameter or deletes a parameter in the Configuration, and it's being tested, then these tests will fail, and they will know right away.
Related Issues
N/A