Fix and Improve Freeze Feature comment #26959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjasonsmith
approved these changes
Apr 13, 2024
sjasonsmith
reviewed
Apr 20, 2024
|
I think this is a useful clarification. The previous wording would have implied to me that this would stop anything potentially dangerous, which is certainly not the case if it could be leaving lasers, spindles, or heaters active. If this functionality sees much use, I expect it will be built upon to allow more granular control over what exactly it shuts down. |
RPGFabi
pushed a commit
to RPGFabi/Marlin
that referenced
this pull request
Jun 15, 2024
* Fix and Improve Freeze Feature comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in issue #26510 the FREEZE_FEATURE does not stop lasers or spindles. This updates the comment to be clear that only stepper motion is stopped.
Removed the term "Emergency" as there is no safety rated emergency stop feature, and something only pausing motion has absolutely no place in an emergency process.