-
-
Notifications
You must be signed in to change notification settings - Fork 19.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mount sdcard early for POWER_LOSS_RECOVERY #27177
Merged
thinkyhead
merged 2 commits into
MarlinFirmware:bugfix-2.1.x
from
ellensp:fis-POWER_LOSS_RECOVERY-crash
Jun 16, 2024
Merged
mount sdcard early for POWER_LOSS_RECOVERY #27177
thinkyhead
merged 2 commits into
MarlinFirmware:bugfix-2.1.x
from
ellensp:fis-POWER_LOSS_RECOVERY-crash
Jun 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
I can confirm that this fixes crashing on macOS Monterey 12.7.5 & Windows 10 x64 (22H2 / OS Build 19045.4412). |
thinkyhead
pushed a commit
that referenced
this pull request
Jun 16, 2024
thinkyhead
pushed a commit
that referenced
this pull request
Jun 16, 2024
thinkyhead
pushed a commit
that referenced
this pull request
Jun 16, 2024
melinerunen
added a commit
to melinerunen/Marlin-ender3
that referenced
this pull request
Jun 25, 2024
….1.2.1 * '2.1.2.1' of github.com:melinerunen/Marlin-ender3: (655 commits) [cron] Bump distribution date (2024-06-22) 🔧 Warning for ZV Shaping on CoreQZ (MarlinFirmware#27200) [cron] Bump distribution date (2024-06-20) 🔨 Fatal error for wrong GCC on macOS Native Sim [cron] Bump distribution date (2024-06-17) 🔧 Nonlinear Extrusion optional Adaptive Smoothing (MarlinFirmware#27175) ♻️ DISABLE_ENCODER => NO_BACK_MENU_ITEM (MarlinFirmware#27180) 🐛 Mount media early for POWER_LOSS_RECOVERY (MarlinFirmware#27177) [cron] Bump distribution date (2024-06-16) 🐛 Fix homing when FT Motion exists (MarlinFirmware#27179) 🧑💻 Adjust pulse_phase_isr code guards (MarlinFirmware#27112) ⚡️ Optimize LPC176x set_pwm_duty (MarlinFirmware#27178) [cron] Bump distribution date (2024-06-15) 🔨 Build scripts cleanup (MarlinFirmware#27157) [cron] Bump distribution date (2024-06-14) 🐛 Fix step oversampling with NONLINEAR_EXTRUSION (MarlinFirmware#27171) [cron] Bump distribution date (2024-06-13) 🚸 AnyCubic Vyper LCD improvements (MarlinFirmware#27158) [cron] Bump distribution date (2024-06-12) 🔨 Rename AnyCubic Vyper binary (MarlinFirmware#27167) ... # Conflicts: # .editorconfig # .github/ISSUE_TEMPLATE/bug_report.yml # .github/ISSUE_TEMPLATE/feature_request.yml # .github/workflows/bump-date.yml # .github/workflows/check-pr.yml # .github/workflows/ci-build-tests.yml # .github/workflows/clean-closed.yml # .github/workflows/close-stale.yml # .github/workflows/lock-closed.yml # Makefile # Marlin/Configuration.h # Marlin/Configuration_adv.h # Marlin/Marlin.ino # Marlin/Version.h # Marlin/src/HAL/AVR/HAL.h # Marlin/src/HAL/AVR/fastio/fastio_1280.h # Marlin/src/HAL/DUE/HAL_SPI.cpp # Marlin/src/HAL/DUE/inc/SanityCheck.h # Marlin/src/HAL/DUE/usb/osc.h # Marlin/src/HAL/ESP32/u8g_esp32_spi.cpp # Marlin/src/HAL/LINUX/spi_pins.h # Marlin/src/HAL/LPC1768/HAL.cpp # Marlin/src/HAL/LPC1768/HAL.h # Marlin/src/HAL/LPC1768/eeprom_sdcard.cpp # Marlin/src/HAL/LPC1768/spi_pins.h # Marlin/src/HAL/LPC1768/tft/tft_spi.cpp # Marlin/src/HAL/LPC1768/tft/xpt2046.h # Marlin/src/HAL/LPC1768/u8g/u8g_com_HAL_LPC1768_sw_spi.cpp # Marlin/src/HAL/NATIVE_SIM/pinsDebug.cpp # Marlin/src/HAL/NATIVE_SIM/spi_pins.h # Marlin/src/HAL/NATIVE_SIM/tft/xpt2046.h # Marlin/src/HAL/NATIVE_SIM/u8g/u8g_com_sw_spi.cpp # Marlin/src/HAL/SAMD21/u8g/u8g_com_HAL_samd21_shared_hw_spi.cpp # Marlin/src/HAL/STM32/HAL.h # Marlin/src/HAL/STM32/MinSerial.cpp # Marlin/src/HAL/STM32/inc/SanityCheck.h # Marlin/src/HAL/STM32/msc_sd.cpp # Marlin/src/HAL/STM32/tft/tft_fsmc.cpp # Marlin/src/HAL/STM32/tft/tft_fsmc.h # Marlin/src/HAL/STM32/tft/tft_spi.cpp # Marlin/src/HAL/STM32/tft/xpt2046.h # Marlin/src/HAL/STM32F1/HAL.cpp # Marlin/src/HAL/STM32F1/HAL.h # Marlin/src/HAL/STM32F1/tft/xpt2046.h # Marlin/src/HAL/STM32F1/timers.h # Marlin/src/HAL/shared/Delay.cpp # Marlin/src/MarlinCore.cpp # Marlin/src/core/boards.h # Marlin/src/core/debug_section.h # Marlin/src/core/macros.h # Marlin/src/core/mstring.h # Marlin/src/core/serial.cpp # Marlin/src/core/serial.h # Marlin/src/core/types.h # Marlin/src/feature/backlash.cpp # Marlin/src/feature/backlash.h # Marlin/src/feature/bedlevel/bdl/bdl.cpp # Marlin/src/feature/bedlevel/ubl/ubl_G29.cpp # Marlin/src/feature/controllerfan.cpp # Marlin/src/feature/encoder_i2c.cpp # Marlin/src/feature/host_actions.cpp # Marlin/src/feature/hotend_idle.h # Marlin/src/feature/max7219.cpp # Marlin/src/feature/mixing.cpp # Marlin/src/feature/mmu/mmu2.cpp # Marlin/src/feature/mmu/mmu2.h # Marlin/src/feature/pause.cpp # Marlin/src/feature/power.h # Marlin/src/feature/powerloss.cpp # Marlin/src/feature/runout.cpp # Marlin/src/feature/runout.h # Marlin/src/feature/stepper_driver_safety.cpp # Marlin/src/feature/tmc_util.h # Marlin/src/gcode/bedlevel/G35.cpp # Marlin/src/gcode/bedlevel/abl/G29.cpp # Marlin/src/gcode/bedlevel/mbl/G29.cpp # Marlin/src/gcode/bedlevel/ubl/M421.cpp # Marlin/src/gcode/calibrate/G28.cpp # Marlin/src/gcode/calibrate/G33.cpp # Marlin/src/gcode/calibrate/M48.cpp # Marlin/src/gcode/calibrate/M665.cpp # Marlin/src/gcode/config/M200-M205.cpp # Marlin/src/gcode/config/M302.cpp # Marlin/src/gcode/config/M92.cpp # Marlin/src/gcode/control/M111.cpp # Marlin/src/gcode/control/M997.cpp # Marlin/src/gcode/feature/advance/M900.cpp # Marlin/src/gcode/feature/ft_motion/M493.cpp # Marlin/src/gcode/feature/pause/G61.cpp # Marlin/src/gcode/feature/powerloss/M1000.cpp # Marlin/src/gcode/feature/trinamic/M569.cpp # Marlin/src/gcode/gcode.cpp # Marlin/src/gcode/gcode.h # Marlin/src/gcode/host/M114.cpp # Marlin/src/gcode/host/M115.cpp # Marlin/src/gcode/lcd/M0_M1.cpp # Marlin/src/gcode/probe/G30.cpp # Marlin/src/gcode/queue.cpp # Marlin/src/gcode/queue.h # Marlin/src/gcode/stats/M31.cpp # Marlin/src/gcode/stats/M75-M78.cpp # Marlin/src/gcode/temp/M303.cpp # Marlin/src/gcode/temp/M306.cpp # Marlin/src/gcode/temp/M86_M87.cpp # Marlin/src/gcode/units/M149.cpp # Marlin/src/inc/Changes.h # Marlin/src/inc/Conditionals_LCD.h # Marlin/src/inc/Conditionals_adv.h # Marlin/src/inc/Conditionals_post.h # Marlin/src/inc/MarlinConfig.h # Marlin/src/inc/SanityCheck.h # Marlin/src/inc/Version.h # Marlin/src/inc/Warnings.cpp # Marlin/src/lcd/HD44780/marlinui_HD44780.cpp # Marlin/src/lcd/TFTGLCD/marlinui_TFTGLCD.cpp # Marlin/src/lcd/dogm/HAL_LCD_com_defines.h # Marlin/src/lcd/dogm/dogm_Statusscreen.h # Marlin/src/lcd/dogm/marlinui_DOGM.cpp # Marlin/src/lcd/dogm/marlinui_DOGM.h # Marlin/src/lcd/dogm/status_screen_DOGM.cpp # Marlin/src/lcd/dogm/u8g/u8g_dev_st7920_128x64_HAL.cpp # Marlin/src/lcd/dogm/u8g/u8g_dev_tft_upscale_from_128x64.cpp # Marlin/src/lcd/e3v2/common/dwin_api.cpp # Marlin/src/lcd/e3v2/common/dwin_api.h # Marlin/src/lcd/e3v2/common/dwin_color.h # Marlin/src/lcd/e3v2/common/encoder.cpp # Marlin/src/lcd/e3v2/common/encoder.h # Marlin/src/lcd/e3v2/common/limits.h # Marlin/src/lcd/e3v2/creality/dwin.cpp # Marlin/src/lcd/e3v2/creality/dwin.h # Marlin/src/lcd/e3v2/jyersui/dwin.cpp # Marlin/src/lcd/e3v2/jyersui/dwin.h # Marlin/src/lcd/e3v2/marlinui/ui_common.cpp # Marlin/src/lcd/e3v2/proui/bedlevel_tools.cpp # Marlin/src/lcd/e3v2/proui/bedlevel_tools.h # Marlin/src/lcd/e3v2/proui/dwin.cpp # Marlin/src/lcd/e3v2/proui/dwin.h # Marlin/src/lcd/e3v2/proui/dwin_defines.h # Marlin/src/lcd/e3v2/proui/dwin_lcd.cpp # Marlin/src/lcd/e3v2/proui/dwin_lcd.h # Marlin/src/lcd/e3v2/proui/dwin_popup.cpp # Marlin/src/lcd/e3v2/proui/dwin_popup.h # Marlin/src/lcd/e3v2/proui/dwinui.cpp # Marlin/src/lcd/e3v2/proui/dwinui.h # Marlin/src/lcd/e3v2/proui/endstop_diag.cpp # Marlin/src/lcd/e3v2/proui/endstop_diag.h # Marlin/src/lcd/e3v2/proui/gcode_preview.cpp # Marlin/src/lcd/e3v2/proui/lockscreen.cpp # Marlin/src/lcd/e3v2/proui/menus.cpp # Marlin/src/lcd/e3v2/proui/menus.h # Marlin/src/lcd/e3v2/proui/meshviewer.cpp # Marlin/src/lcd/e3v2/proui/meshviewer.h # Marlin/src/lcd/e3v2/proui/plot.cpp # Marlin/src/lcd/e3v2/proui/plot.h # Marlin/src/lcd/e3v2/proui/printstats.cpp # Marlin/src/lcd/e3v2/proui/printstats.h # Marlin/src/lcd/extui/anycubic/common_defs.h # Marlin/src/lcd/extui/anycubic_chiron/chiron_extui.cpp # Marlin/src/lcd/extui/anycubic_chiron/chiron_tft.cpp # Marlin/src/lcd/extui/anycubic_i3mega/anycubic_extui.cpp # Marlin/src/lcd/extui/anycubic_i3mega/anycubic_i3mega_lcd.cpp # Marlin/src/lcd/extui/anycubic_vyper/dgus_tft.cpp # Marlin/src/lcd/extui/anycubic_vyper/dgus_tft.h # Marlin/src/lcd/extui/anycubic_vyper/vyper_extui.cpp # Marlin/src/lcd/extui/dgus/DGUSScreenHandler.cpp # Marlin/src/lcd/extui/dgus/DGUSScreenHandlerBase.h # Marlin/src/lcd/extui/dgus/dgus_extui.cpp # Marlin/src/lcd/extui/dgus/fysetc/DGUSDisplayDef.cpp # Marlin/src/lcd/extui/dgus/hiprecy/DGUSDisplayDef.cpp # Marlin/src/lcd/extui/dgus/mks/DGUSDisplayDef.cpp # Marlin/src/lcd/extui/dgus/mks/DGUSScreenHandler.cpp # Marlin/src/lcd/extui/dgus/mks/DGUSScreenHandler.h # Marlin/src/lcd/extui/dgus/origin/DGUSDisplayDef.cpp # Marlin/src/lcd/extui/dgus_e3s1pro/DGUSDisplay.cpp # Marlin/src/lcd/extui/dgus_e3s1pro/DGUSDisplay.h # Marlin/src/lcd/extui/dgus_e3s1pro/DGUSReturnKeyCodeHandler.cpp # Marlin/src/lcd/extui/dgus_e3s1pro/DGUSRxHandler.cpp # Marlin/src/lcd/extui/dgus_e3s1pro/DGUSRxHandler.h # Marlin/src/lcd/extui/dgus_e3s1pro/DGUSScreenHandler.cpp # Marlin/src/lcd/extui/dgus_e3s1pro/DGUSScreenHandler.h # Marlin/src/lcd/extui/dgus_e3s1pro/DGUSTxHandler.cpp # Marlin/src/lcd/extui/dgus_e3s1pro/config/DGUS_Constants.h # Marlin/src/lcd/extui/dgus_e3s1pro/definition/DGUS_ScreenAddrList.cpp # Marlin/src/lcd/extui/dgus_e3s1pro/dgus_e3s1pro_extui.cpp # Marlin/src/lcd/extui/dgus_reloaded/DGUSDisplay.cpp # Marlin/src/lcd/extui/dgus_reloaded/DGUSRxHandler.cpp # Marlin/src/lcd/extui/dgus_reloaded/DGUSScreenHandler.cpp # Marlin/src/lcd/extui/dgus_reloaded/DGUSScreenHandler.h # Marlin/src/lcd/extui/dgus_reloaded/dgus_reloaded_extui.cpp # Marlin/src/lcd/extui/example/example.cpp # Marlin/src/lcd/extui/ftdi_eve_touch_ui/cocoa_press/leveling_menu.cpp # Marlin/src/lcd/extui/ftdi_eve_touch_ui/cocoa_press/status_screen.cpp # Marlin/src/lcd/extui/ftdi_eve_touch_ui/ftdi_eve_extui.cpp # Marlin/src/lcd/extui/ftdi_eve_touch_ui/theme/bootscreen_logo_portrait.h # Marlin/src/lcd/extui/ia_creality/FileNavigator.cpp # Marlin/src/lcd/extui/ia_creality/ia_creality_extui.cpp # Marlin/src/lcd/extui/ia_creality/ia_creality_rts.cpp # Marlin/src/lcd/extui/malyan/malyan_extui.cpp # Marlin/src/lcd/extui/mks_ui/draw_jerk_settings.cpp # Marlin/src/lcd/extui/mks_ui/tft_lvgl_configuration.h # Marlin/src/lcd/extui/nextion/nextion_extui.cpp # Marlin/src/lcd/extui/nextion/nextion_tft.cpp # Marlin/src/lcd/extui/ui_api.cpp # Marlin/src/lcd/extui/ui_api.h # Marlin/src/lcd/language/language_de.h # Marlin/src/lcd/language/language_en.h # Marlin/src/lcd/language/language_fr.h # Marlin/src/lcd/language/language_fr_na.h # Marlin/src/lcd/language/language_it.h # Marlin/src/lcd/language/language_jp_kana.h # Marlin/src/lcd/language/language_ru.h # Marlin/src/lcd/language/language_sk.h # Marlin/src/lcd/language/language_tr.h # Marlin/src/lcd/language/language_uk.h # Marlin/src/lcd/language/language_zh_CN.h # Marlin/src/lcd/language/language_zh_TW.h # Marlin/src/lcd/lcdprint.cpp # Marlin/src/lcd/lcdprint.h # Marlin/src/lcd/marlinui.cpp # Marlin/src/lcd/marlinui.h # Marlin/src/lcd/menu/menu.h # Marlin/src/lcd/menu/menu_advanced.cpp # Marlin/src/lcd/menu/menu_bed_corners.cpp # Marlin/src/lcd/menu/menu_bed_leveling.cpp # Marlin/src/lcd/menu/menu_configuration.cpp # Marlin/src/lcd/menu/menu_info.cpp # Marlin/src/lcd/menu/menu_item.h # Marlin/src/lcd/menu/menu_main.cpp # Marlin/src/lcd/menu/menu_media.cpp # Marlin/src/lcd/menu/menu_motion.cpp # Marlin/src/lcd/menu/menu_one_click_print.cpp # Marlin/src/lcd/tft/canvas.cpp # Marlin/src/lcd/tft/fontdata/Helvetica/Helvetica_19.cpp # Marlin/src/lcd/tft/fontdata/Unifont/LICENSE-OFL-1.1 # Marlin/src/lcd/tft/images/time_elapsed_32x32x4.cpp # Marlin/src/lcd/tft/images/time_remaining_32x32x4.cpp # Marlin/src/lcd/tft/tft_color.h # Marlin/src/lcd/tft/tft_string.cpp # Marlin/src/lcd/tft/touch.cpp # Marlin/src/lcd/tft/touch.h # Marlin/src/lcd/tft/ui_color_ui.cpp # Marlin/src/lcd/tft/ui_common.cpp # Marlin/src/lcd/tft/ui_common.h # Marlin/src/lcd/thermistornames.h # Marlin/src/lcd/touch/touch_buttons.cpp # Marlin/src/libs/nozzle.cpp # Marlin/src/libs/numtostr.cpp # Marlin/src/module/endstops.cpp # Marlin/src/module/ft_motion.cpp # Marlin/src/module/ft_motion.h # Marlin/src/module/ft_types.h # Marlin/src/module/motion.cpp # Marlin/src/module/motion.h # Marlin/src/module/planner.cpp # Marlin/src/module/planner.h # Marlin/src/module/probe.cpp # Marlin/src/module/settings.cpp # Marlin/src/module/stepper.cpp # Marlin/src/module/stepper.h # Marlin/src/module/stepper/TMC26X.cpp # Marlin/src/module/stepper/TMC26X.h # Marlin/src/module/stepper/cycles.h # Marlin/src/module/temperature.cpp # Marlin/src/module/temperature.h # Marlin/src/module/thermistor/thermistor_14.h # Marlin/src/module/tool_change.cpp # Marlin/src/pins/esp32/pins_MKS_TINYBEE.h # Marlin/src/pins/esp32/pins_MM_JOKER.h # Marlin/src/pins/esp32/pins_PANDA_ZHU.h # Marlin/src/pins/gd32f1/pins_SOVOL_V131.h # Marlin/src/pins/gd32f1/pins_TRIGORILLA_V006.h # Marlin/src/pins/lpc1768/pins_BTT_SKR_V1_3.h # Marlin/src/pins/lpc1768/pins_BTT_SKR_V1_4.h # Marlin/src/pins/lpc1768/pins_MKS_SBASE.h # Marlin/src/pins/lpc1768/pins_RAMPS_RE_ARM.h # Marlin/src/pins/lpc1769/pins_AZTEEG_X5_MINI.h # Marlin/src/pins/lpc1769/pins_COHESION3D_REMIX.h # Marlin/src/pins/lpc1769/pins_SMOOTHIEBOARD.h # Marlin/src/pins/mega/pins_GT2560_REV_A.h # Marlin/src/pins/mega/pins_GT2560_REV_A_PLUS.h # Marlin/src/pins/mega/pins_GT2560_V3_A20.h # Marlin/src/pins/mega/pins_GT2560_V41b.h # Marlin/src/pins/mega/pins_GT2560_V4_A20.h # Marlin/src/pins/mega/pins_PICA.h # Marlin/src/pins/mega/pins_PICAOLD.h # Marlin/src/pins/native/pins_RAMPS_NATIVE.h # Marlin/src/pins/pins.h # Marlin/src/pins/pins_postprocess.h # Marlin/src/pins/rambo/pins_EINSY_RETRO.h # Marlin/src/pins/rambo/pins_MINIRAMBO.h # Marlin/src/pins/ramps/pins_FELIX2.h # Marlin/src/pins/ramps/pins_FYSETC_F6_13.h # Marlin/src/pins/ramps/pins_K8400.h # Marlin/src/pins/ramps/pins_MKS_GEN_13.h # Marlin/src/pins/ramps/pins_RAMPS.h # Marlin/src/pins/ramps/pins_RAMPS_CREALITY.h # Marlin/src/pins/ramps/pins_RUMBA.h # Marlin/src/pins/ramps/pins_TT_OSCAR.h # Marlin/src/pins/ramps/pins_ULTIMAKER_OLD.h # Marlin/src/pins/ramps/pins_ZRIB_V53.h # Marlin/src/pins/samd/pins_RAMPS_144.h # Marlin/src/pins/sanguino/pins_ANET_10.h # Marlin/src/pins/sanguino/pins_AZTEEG_X1.h # Marlin/src/pins/sanguino/pins_MELZI_CREALITY.h # Marlin/src/pins/sanguino/pins_MELZI_CREALITY_E2.h # Marlin/src/pins/sanguino/pins_MELZI_TRONXY.h # Marlin/src/pins/sanguino/pins_SANGUINOLOLU_11.h # Marlin/src/pins/sanguino/pins_ZMIB_V2.h # Marlin/src/pins/stm32f1/pins_BTT_SKR_MINI_E3_common.h # Marlin/src/pins/stm32f1/pins_BTT_SKR_MINI_V1_1.h # Marlin/src/pins/stm32f1/pins_CREALITY_V25S1.h # Marlin/src/pins/stm32f1/pins_KEDI_CONTROLLER_V1_2.h # Marlin/src/pins/stm32f1/pins_LONGER3D_LK.h # Marlin/src/pins/stm32f1/pins_MKS_ROBIN_E3P.h # Marlin/src/pins/stm32f1/pins_MKS_ROBIN_E3_common.h # Marlin/src/pins/stm32f1/pins_MKS_ROBIN_NANO_V2.h # Marlin/src/pins/stm32f1/pins_MKS_ROBIN_PRO.h # Marlin/src/pins/stm32f1/pins_TRIGORILLA_PRO.h # Marlin/src/pins/stm32f4/pins_BLACKPILL_CUSTOM.h # Marlin/src/pins/stm32f4/pins_BTT_E3_RRF.h # Marlin/src/pins/stm32f4/pins_BTT_GTR_V1_0.h # Marlin/src/pins/stm32f4/pins_BTT_OCTOPUS_V1_common.h # Marlin/src/pins/stm32f4/pins_BTT_SKR_V2_0_common.h # Marlin/src/pins/stm32f4/pins_CREALITY_F401.h # Marlin/src/pins/stm32f4/pins_I3DBEEZ9.h # Marlin/src/pins/stm32f4/pins_MELLOW_FLY_E3_V2.h # Marlin/src/pins/stm32f4/pins_MKS_MONSTER8_common.h # Marlin/src/pins/stm32f4/pins_MKS_ROBIN_PRO_V2.h # Marlin/src/pins/stm32f4/pins_RUMBA32_common.h # Marlin/src/pins/stm32f4/pins_TH3D_EZBOARD_V2.h # Marlin/src/pins/stm32f4/pins_TRONXY_V10.h # Marlin/src/pins/stm32g0/pins_BTT_MANTA_E3_EZ_V1_0.h # Marlin/src/pins/stm32g0/pins_BTT_SKR_MINI_E3_V3_0.h # Marlin/src/pins/stm32h7/pins_BTT_OCTOPUS_MAX_EZ.h # Marlin/src/pins/stm32h7/pins_BTT_OCTOPUS_PRO_V1_1.h # Marlin/src/pins/stm32h7/pins_BTT_SKR_SE_BX_common.h # Marlin/src/pins/stm32h7/pins_BTT_SKR_V3_0_common.h # Marlin/src/sd/Sd2Card.h # Marlin/src/sd/cardreader.cpp # Marlin/src/sd/usb_flashdrive/Sd2Card_FlashDrive.h # README.md # buildroot/share/PlatformIO/scripts/add_nanolib.py # buildroot/share/PlatformIO/scripts/common-dependencies.py # buildroot/share/PlatformIO/scripts/generic_create_variant.py # buildroot/share/PlatformIO/scripts/preflight-checks.py # buildroot/share/PlatformIO/variants/MARLIN_CREALITY_STM32F401RE/variant.h # buildroot/share/cmake/CMakeLists.txt # buildroot/share/dwin/icons-6/009-ICON_HotendTemp.jpg # buildroot/share/dwin/icons-6/011-ICON_Speed.jpg # buildroot/share/dwin/icons-6/012-ICON_Zoffset.jpg # buildroot/share/dwin/icons-6/019-ICON_Pause_0.jpg # buildroot/share/dwin/icons-6/020-ICON_Pause_1.jpg # buildroot/share/dwin/icons-6/030-ICON_SetHome.jpg # buildroot/share/dwin/icons-6/034-ICON_Language.jpg # buildroot/share/dwin/icons-6/035-ICON_MoveX.jpg # buildroot/share/dwin/icons-6/036-ICON_MoveY.jpg # buildroot/share/dwin/icons-6/037-ICON_MoveZ.jpg # buildroot/share/dwin/icons-6/038-ICON_Extruder.jpg # buildroot/share/dwin/icons-6/040-ICON_Temperature.jpg # buildroot/share/dwin/icons-6/041-ICON_Motion.jpg # buildroot/share/dwin/icons-6/045-ICON_Info.jpg # buildroot/share/dwin/icons-6/046-ICON_SetEndTemp.jpg # buildroot/share/dwin/icons-6/047-ICON_SetBedTemp.jpg # buildroot/share/dwin/icons-6/051-ICON_MaxSpeed.jpg # buildroot/share/dwin/icons-6/052-ICON_MaxAccelerated.jpg # buildroot/share/dwin/icons-6/053-ICON_MaxJerk.jpg # buildroot/share/dwin/icons-6/054-ICON_Step.jpg # buildroot/share/dwin/icons-6/058-ICON_StockConfiguraton.jpg # buildroot/share/dwin/icons-6/059-ICON_MaxSpeedX.jpg # buildroot/share/dwin/icons-6/060-ICON_MaxSpeedY.jpg # buildroot/share/dwin/icons-6/061-ICON_MaxSpeedZ.jpg # buildroot/share/dwin/icons-6/062-ICON_MaxSpeedE.jpg # buildroot/share/dwin/icons-6/063-ICON_MaxAccX.jpg # buildroot/share/dwin/icons-6/064-ICON_MaxAccY.jpg # buildroot/share/dwin/icons-6/065-ICON_MaxAccZ.jpg # buildroot/share/dwin/icons-6/066-ICON_MaxAccE.jpg # buildroot/share/dwin/icons-6/067-ICON_MaxSpeedJerkX.jpg # buildroot/share/dwin/icons-6/068-ICON_MaxSpeedJerkY.jpg # buildroot/share/dwin/icons-6/069-ICON_MaxSpeedJerkZ.jpg # buildroot/share/dwin/icons-6/070-ICON_MaxSpeedJerkE.jpg # buildroot/share/dwin/icons-6/071-ICON_StepX.jpg # buildroot/share/dwin/icons-6/072-ICON_StepY.jpg # buildroot/share/dwin/icons-6/073-ICON_StepZ.jpg # buildroot/share/dwin/icons-6/074-ICON_StepE.jpg # buildroot/share/dwin/icons-6/075-ICON_Setspeed.jpg # buildroot/share/dwin/icons-6/076-ICON_SetZOffset.jpg # buildroot/share/dwin/icons-6/078-ICON_BLTouch.jpg # buildroot/share/dwin/icons-6/079-ICON_TempTooLow.jpg # buildroot/share/dwin/icons-6/081-ICON_TempTooHigh.jpg # buildroot/share/scripts/MarlinBinaryProtocol.py # buildroot/share/scripts/languageImport.py # buildroot/share/scripts/languageUtil.py # buildroot/share/scripts/rle16_compress_cpp_image_data.py # buildroot/share/scripts/upload.py # buildroot/tests/BIGTREE_GTR_V1_0 # buildroot/tests/STM32F103RC_btt # buildroot/tests/STM32F103RC_btt_USB # buildroot/tests/STM32F103RE_creality # buildroot/tests/mega2560 # buildroot/tests/rambo # buildroot/tests/teensy35 # ini/features.ini # ini/native.ini # ini/stm32f1-maple.ini # ini/stm32f4.ini # ini/stm32g0.ini # ini/stm32h7.ini # platformio.ini
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was noticed in the simulator that enabling POWER_LOSS_RECOVERY caused it to crash #26541
An exception is generated on
int8_t fatType() const { return fatType_; }
Examining the vol structure shows it has not yet been populated, so attempting to read fatType_ causes an exception.
My solution is to mount the SDCARD earlier, there is already code for this for SDCARD_EEPROM_EMULATION
I updated the test to now also look for POWER_LOSS_RECOVERY to mount the sdcard early.
Requirements
POWER_LOSS_RECOVERY
Benefits
Simulator doesn't crash, and I presume POWER_LOSS_RECOVERY has a better chance of working as it should
Related Issues