Rename fpos_t to avoid libc conflict #2992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick question: Why is the new SD File System so hard to merge into the Marlin code base? What is different that is causing all the problems? |
@Roxy-3DPrintBoard I went through the process of trying to update the SD code to use a newer SdFat a while ago, but only the "SdFat Beta" branch had long filename support at the time. Now it looks like the long filename support has finally been added to the main branch. So it might be worth a try again. We had to hack SdFat to accomplish certain tricks for Marlin. Hopefully with a newer version we won't have to do those hacks. |
thinkyhead
added a commit
that referenced
this pull request
Feb 17, 2016
Rename fpos_t to avoid libc conflict
This was referenced Mar 19, 2016
Closed
tommie
added a commit
to tommie/Marlin
that referenced
this pull request
Jan 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses compile failure reported in #2966