Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Danish language pack #3932

Merged
merged 1 commit into from
May 31, 2016
Merged

Update Danish language pack #3932

merged 1 commit into from
May 31, 2016

Conversation

boelle
Copy link
Contributor

@boelle boelle commented May 31, 2016

No description provided.

@Roxy-3D Roxy-3D merged commit 3d7d034 into MarlinFirmware:RCBugFix May 31, 2016
@jbrazio jbrazio changed the title initial changes to DA Update Danish language pack May 31, 2016
@jbrazio jbrazio added this to the 1.1.0 milestone May 31, 2016
@jbrazio
Copy link
Contributor

jbrazio commented May 31, 2016

@boelle please use more descriptive commit messages like "Update Danish language pack" or "Initial update of the Danish language pack". Titles we can change/edit but commit messages we cannot.

@thinkyhead
Copy link
Member

Titles we can change/edit but commit messages we cannot.

Well, we can edit commit messages, but we have to make a copy of the branch and submit a new PR to do it.

@thinkyhead
Copy link
Member

thinkyhead commented Jun 1, 2016

@boelle The Germans did a lot of work, and quite a challenge it was, to reduce string lengths to 18 characters or less, with the most important part of the strings in the first 16 characters, as this is the minimum width of the screen. Ideally, we want to make these LCD display strings 16 characters at the most.

Strings over 20 characters are a complete waste, as we will never display the additional characters (at least not until all LCD messages are scrolling). Characters past 20 are just wasted bytes, so you might as well cut the strings off at 20.

@Roxy-3D
Copy link
Member

Roxy-3D commented Jun 1, 2016

(at least not until all LCD messages are scrolling)

Yikes! More CPU cycles to scroll! At least the Full Graphics Panels won't
need to be scrolling. Those are the biggest pigs of CPU cycles.

Seriously.... This is yet another example why we need to get the 32-Bit
support in place. We need the horse power to deal with these kinds of
problems.

On Tue, May 31, 2016 at 8:23 PM, Scott Lahteine notifications@github.com
wrote:

@boelle https://github.com/boelle The Germans did a lot of work, and
quite a challenge it was, to reduce string lengths to 18 characters or
less, with the most important part of the strings in the first 16
characters, as this is the minimum width of the screen. So, ideally, we
want to make strings 16 characters at the most.

Strings over 20 characters are a complete waste, as we will never display
the additional characters (at least not until all LCD messages are
scrolling). Characters past 20 are just wasted bytes, so you might as well
cut the strings off at 20.


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#3932 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AIA9YlftJjtZNF9EUkVI44Hc7uvkiEazks5qHN8LgaJpZM4Iqevl
.

@thinkyhead
Copy link
Member

need the horse power to deal with these kinds of problems.

It will help. But of course, we might still have to backward-support slower hardware — at least if the 32-bit version is the same code-base as this Marlin. But I expect we will be making a whole separate repo for the 32-bit version.

@jbrazio
Copy link
Contributor

jbrazio commented Jun 1, 2016

making a whole separate repo for the 32-bit version

IMO we shall decide after refactoring the existing code and looking at the HAL.

@thinkyhead thinkyhead mentioned this pull request Jul 8, 2016
drewmoseley pushed a commit to drewmoseley/Marlin that referenced this pull request Nov 8, 2023
…Version_change

Version changed (3.12.1 build 5684) for FW3.12.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants