Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify LCD_BED_LEVELING requirements #7398

Conversation

fiveangle
Copy link
Contributor

@fiveangle fiveangle commented Aug 1, 2017

LCD_BED_LEVELING requires MBL or PROBE_MANUALLY with auto bed leveling enabled. See #7396

LCD_BED_LEVELING requires PROBE_MANUALLY with auto bed leveling enabled.  See MarlinFirmware#7396
@thinkyhead
Copy link
Member

I suppose that helps, but of course one cannot enable auto bed leveling at all without enabling either PROBE_MANUALLY or one of the other probes.

@thinkyhead thinkyhead merged commit ce65c13 into MarlinFirmware:bugfix-1.1.x Aug 1, 2017
@fiveangle
Copy link
Contributor Author

fiveangle commented Aug 1, 2017

You're preaching to the choir. The trouble is user enables PROBE_MANUALLY and LCD_BED_LEVELING, thinks it should work, doesn't accept that it also requires ABL, and holds the SanityCheck.h error up as evidence. o_O

@fiveangle fiveangle deleted the bf_lcd_bed_level_requirements branch August 1, 2017 22:54
@Roxy-3D
Copy link
Member

Roxy-3D commented Aug 1, 2017

I suppose that helps, but of course one cannot enable auto bed leveling at all without enabling either PROBE_MANUALLY or one of the other probes.

Technically... That is not true. Because UBL has manual probing code built into its G29 P2 command....
Or alternatively... The user could just do a G29 P0 to zero the mesh... Then use G26 and G29 P4 to edit the mesh into a usable state....

But really.... The user should have a probe!

@fiveangle
Copy link
Contributor Author

One could argue that UBL should be "fixed" to require PROBE_MANUALLY before enabling the feature then ;)

@Roxy-3D
Copy link
Member

Roxy-3D commented Aug 1, 2017

Well.... What we really need to do is ALWAYS allow a manual probe option. And allow that to be mixed with automated Z-Probing.... But that is very difficult to do without re-writing all the probe code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants