-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.1.x] led control menu #8488
[1.1.x] led control menu #8488
Conversation
7d17ad2
to
049426e
Compare
I'm cleaning this up and will push the updated HEAD for your review when it's ready. |
2b3b975
to
6cf9ae4
Compare
I've rebased and applied several patches to this PR. git checkout 1.1.x-led_control_menu
git fetch origin
git reset --hard origin/1.1.x-led_control_menu Changes include:
As with any big set of changes, there may be bugs. Please test whenever you have a chance. |
41462ff
to
f85db55
Compare
Marlin/Configuration_adv.h
Outdated
#define LED_USER_PRESET_BLUE 0 // User defined BLUE value | ||
#define LED_USER_PRESET_WHITE 255 // User defined WHITE value | ||
#define LED_USER_PRESET_INTENSITY 255 // User defined intensity | ||
//#define LED_USER_PRESET_STARTUP // Have the printer display the user preset color on startup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tannoo What is the normal startup state for the LEDs? I assume they are simply turned off by default. Is this option intended to have the LEDs set to a certain color whenever Marlin re-starts (as it does on host connect)? I didn't see any code added to Marlin's init()
function as a result of this setting, but only an interesting bool
flag in ultralcd.cpp
.
f85db55
to
8db7039
Compare
Maybe an advanced config for setting the start-up led state/colour? |
99e0805
to
7f6a42e
Compare
A Set Default LED menu item would suffice, and then code to save/load the set color from EEPROM. |
d0bc277
to
b3112a9
Compare
3b4ed87
to
d4c2852
Compare
1335b45
to
6153927
Compare
6153927
to
68c1f05
Compare
Gives control of LEDs from the LCD.