Add Dockerfile #44
Add Dockerfile #44
Conversation
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
=========================================
Coverage 60.75% 60.75%
Complexity 159 159
=========================================
Files 40 40
Lines 795 795
Branches 77 77
=========================================
Hits 483 483
Misses 270 270
Partials 42 42Continue to review full report at Codecov.
|
wslulciuc
force-pushed
the
docker
branch
2 times, most recently
from
64045fc
to
52f0599
Compare
Dockerfile
Outdated
| COPY . /usr/src/app | ||
| RUN ./gradlew clean build | ||
|
|
||
| FROM openjdk:9-jre-slim |
There was a problem hiding this comment.
base docker image seems to be written twice
There was a problem hiding this comment.
I'm leveraging multi-stage builds to keep things compact and cache gradle specific scripts, libs, etc.
Dockerfile
Outdated
| WORKDIR /usr/src/app | ||
| COPY --from=build /usr/src/app/build/libs/marquez-all.jar marquez.jar | ||
| EXPOSE 5000 | ||
| ENTRYPOINT ["java", "-jar", "marquez.jar", "server", "$MARQUEZ_CONFG"] |
There was a problem hiding this comment.
nit: ${MARQUEZ_CONFIG}, for stylistic consistency.
Also CONFG -> CONFIG?
There was a problem hiding this comment.
Good catch! Also, still figuring out what the best approach would be to set config.yml.
* Update status code field in MarquezHttpException * Simplify MarquezHttp.url()
Signed-off-by: wslulciuc <willy@datakin.com>
No description provided.