Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue3 support #22

Merged
merged 28 commits into from
Sep 26, 2020
Merged

Vue3 support #22

merged 28 commits into from
Sep 26, 2020

Conversation

MartinMalinda
Copy link
Owner

@MartinMalinda MartinMalinda commented Sep 25, 2020

  • make tests pass with Vue 3
  • make tests pass both for Vue 2 and Vue 3
  • bundle both for Vue 2 and Vue 3
  • put both vue2 and vue3 bundle in dist and add index.js that lets the consumer choose the right one
  • make the docs work
  • test in Vue 2 and Vue 3 app via npm install

@ghost
Copy link

ghost commented Sep 25, 2020

DeepCode's analysis on #df3761 found:

  • ℹ️ 3 minor issues. 👇

Top issues

Description Example fixes
No catch method for promise. This may result in an unhandled promise rejection. Occurrences: 🔧 Example fixes
Use "utf8", which Node uses, instead of "utf-8" (in fs.writeFileSync). Occurrences: 🔧 Example fixes
No catch method for promise. This may result in an unhandled promise rejection. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@leventekobor
Copy link

❤️

@MartinMalinda MartinMalinda changed the title WIP: Vue3 support Vue3 support Sep 26, 2020
@MartinMalinda MartinMalinda merged commit 7103114 into master Sep 26, 2020
@MartinMalinda MartinMalinda deleted the vue3-support branch November 13, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants