fix(spoon): Fix whitespaces in ruleIDs for spoon analyzer (#854)

github-bot/src/main/java/io/github/martinwitt/laughing_train/persistence/DataBaseMigration.java

@@ -2,6 +2,7 @@
 
 import com.google.common.flogger.FluentLogger;
 import com.mongodb.client.model.Filters;
+import com.mongodb.client.result.DeleteResult;
 import io.github.martinwitt.laughing_train.domain.entity.Project;
 import io.github.martinwitt.laughing_train.domain.entity.ProjectConfig;
 import io.github.martinwitt.laughing_train.persistence.impl.MongoBadSmellRepository;
@@ -67,6 +68,7 @@ private void migrateDataBase(Promise<Object> promise) {
         removeProjectHashesWithoutResults();
         removeProjectsWithOutHashes();
         removeDuplicatedProjects();
+        removeRuleIdsWithSpaces();
         logger.atInfo().log("Finished migrating database");
         promise.complete();
     }
@@ -120,4 +122,11 @@ private void removeDuplicatedProjects() {
                 .forEach(project -> projectRepository.deleteByProjectUrl(project.getProjectUrl()));
         logger.atInfo().log("Finished removing duplicated projects");
     }
+
+    private void removeRuleIdsWithSpaces() {
+        DeleteResult deleteMany = badSmellRepositoryImpl
+                .mongoCollection()
+                .deleteMany(Filters.and(Filters.regex("ruleID", ".*\s.*"), Filters.eq("analyzer", "Spoon")));
+        logger.atInfo().log("Removed %d bad smells with ruleId containing spaces", deleteMany.getDeletedCount());
+    }
 }

spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/innerclass_may_be_static/InnerClassMayBeStatic.java

@@ -8,7 +8,7 @@ public class InnerClassMayBeStatic implements BadSmell {
 
     private final CtType<?> affectedType;
     private final CtType<?> innerClass;
-    private static final String name = "Inner Class May Be Static";
+    private static final String name = "InnerClassMayBeStatic";
     private static final String description =
             "This class is an inner class and may be static. Static inner classes dont need the reference to the outer class.";
 

spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/unnecessary_implements/UnnecessaryImplements.java

@@ -7,7 +7,7 @@
 
 public class UnnecessaryImplements implements BadSmell {
 
-    private final String name = "Unnecessary Implements";
+    private final String name = "UnnecessaryImplements";
     private final String description = "This class has 1 or more interfaces which are already implemented.";
 
     private final CtTypeReference<?> lowerType;