Create MANIFEST.in #198
Closed
Create MANIFEST.in #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @raybellwaves ! THanks for the PR, and my apologies for taking a look at it so ridiculously late. Could you give me a quick idea of why we should add MANIFEST.in, what is this solving? |
|
Was recommended when creating a conda package |
|
Got it, thanks! I do have MANIFEST.in in bindings/python, but here at the top level, I don't really understand why we should have it. And since this is the only request for it + not very detailed, I will be closing it, but we can reopen if it turns out there is a strong need for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.