Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add control over regex options #74

Merged

Conversation

ricsiLT
Copy link
Contributor

@ricsiLT ricsiLT commented Aug 21, 2023

No description provided.

@ricsiLT ricsiLT mentioned this pull request Aug 21, 2023
src/Grok.Net/Grok.cs Outdated Show resolved Hide resolved
src/Grok.Net/Grok.cs Outdated Show resolved Hide resolved
src/Grok.Net/Grok.cs Outdated Show resolved Hide resolved
src/Grok.Net/Grok.cs Outdated Show resolved Hide resolved
src/Grok.Net/Grok.cs Outdated Show resolved Hide resolved
src/Grok.Net/Grok.cs Outdated Show resolved Hide resolved
src/Grok.Net.Tests/UnitTests.cs Outdated Show resolved Hide resolved
@Marusyk Marusyk linked an issue Aug 21, 2023 that may be closed by this pull request
@Marusyk Marusyk added this to the 1.2.0 milestone Aug 21, 2023
@Marusyk Marusyk added the enhancement New feature or request label Aug 21, 2023
@ricsiLT
Copy link
Contributor Author

ricsiLT commented Aug 22, 2023

I think I covered most if it. Shout if I forgot something!

Copy link
Owner

@Marusyk Marusyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM but small thing in tests

src/Grok.Net.Tests/UnitTests.cs Show resolved Hide resolved
@Marusyk Marusyk merged commit d728697 into Marusyk:main Aug 26, 2023
3 checks passed
@Marusyk
Copy link
Owner

Marusyk commented Aug 26, 2023

@ricsiLT Thanks a lot for your contribution!

@ricsiLT
Copy link
Contributor Author

ricsiLT commented Aug 28, 2023

@Marusyk no problem, I needed this feature for my OCD :D Will you be releasing 1.2 soon? Or will you wait until 2.0 with new PCRE engine?

@Marusyk
Copy link
Owner

Marusyk commented Aug 28, 2023

1.2 will be released by the end of this week. The 2.0 in ~1mo

@Marusyk
Copy link
Owner

Marusyk commented Aug 29, 2023

@ricsiLT 1.2.0 has been released 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiline strings
3 participants